Commit Graph

142 Commits

Author SHA1 Message Date
Wieland Hoffmann
526777edd7 Merge pull request #482 from scop/links
Link updates
2016-07-31 09:17:16 +02:00
Wieland Hoffmann
9de9ac069c Merge pull request #483 from scop/spelling
Spelling fixes
2016-07-31 09:16:32 +02:00
Ville Skyttä
dcf60ac700 Handle more file closing with "with" 2016-07-31 09:36:11 +03:00
Ville Skyttä
9ed5c65230 Link updates 2016-07-31 09:27:07 +03:00
Ville Skyttä
b1819ec37c Spelling fixes 2016-07-31 09:26:21 +03:00
Wieland Hoffmann
fb627c84bc Move all the QUrl building to util.build_qurl 2015-10-06 10:25:25 +02:00
Wieland Hoffmann
0826730616 Increment the version of addrelease.py
This should have been done a while ago already because there have been
some commits which fix bugs, but...
2015-01-11 13:47:32 +01:00
Philipp Wolfer
f10ecc45f2 lastfmplus: Remove random line breaks from tooltips.
Fixes PICARD-655
2014-11-15 13:25:51 +01:00
Wieland Hoffmann
84ffe3502f Fix the last commit
because I forgot to `git add` the file again
2014-06-28 21:14:13 +02:00
Wieland Hoffmann
50bc0755af Reset self.form_values after generating the HTML file
Otherwise, :qa
2014-06-28 21:12:52 +02:00
Laurent Monin
e5953457b6 Not having 'relation_list' is not invalid, do not emit error message
Error message is still emitted if metadata has no artist (which shouldn't happen for artist query)

E: 17:27:06 Album Artist Website: u'2451caed-5d09-456f-b640-5880b6060a64': MusicBrainz artist xml result not in correct format - {'attribs': {}, 'text': u'', 'children': {u'metadata': [{'attribs': {}, 'text': u'', 'children': {u'artist': [{'attribs': {u'type': u'Group', u'id': u'2451caed-5d09-456f-b640-5880b6060a64'}, 'text': u'', 'children': {u'name': [{'attribs': {}, 'text': u'Sir Frankie Crisp', 'children': {}}], u'sort_name': [{'attribs': {}, 'text': u'Sir Frankie Crisp', 'children': {}}]}}]}}]}}
2014-06-20 10:10:10 +02:00
Laurent Monin
033d88362b Fix up albumartist_website plugin debug message
Traceback (most recent call last):
  File "picard\webservice.pyo", line 285, in _process_reply
  File "C:\Program Files (x86)\MusicBrainz Picard\plugins\albumartist_website.py", line 95, in website_process
    log.debug("%s: %r: Artist Official Homepages = %s", PLUGIN_NAME, artistId, url)
NameError: global name 'url' is not defined
2014-06-20 10:01:16 +02:00
Laurent Monin
751f2b64f7 PICARD-597: use named place holders in translatable strings
- modify set_statusbar_message(): drop hacky %s replacement, it shouldn't be needed anyway
- add named arguments echo and translate to it, to cover all needs
- rewrite translatable strings to use named place holders
- fix up some messages, add plural forms if needed

http://tickets.musicbrainz.org/browse/PICARD-597
2014-05-03 17:09:50 +02:00
Sophist
10f55d5df3 Tweak Standardise Performers
Since we have a try/except block so that this will run on previous
versions, tweak the API_VERSIONS so that it will load on these versions
of Picard.
2014-05-03 07:08:24 +01:00
Laurent Monin
645aa64c15 log.warning() will take care of format parameters, '%' -> ',' 2014-04-25 19:11:35 +02:00
Laurent Monin
23ef8465f9 Try to run on previous Picard versions at normal priority.
Since there is no PluginPriority on previous Picard versions, this plugin will
raise an exception, better catch it and emit a warning.

Sophist said:
"It will work in most cases at normal priority, but any other plugins that run before it will get the old performers rather than the standardized performers.
2014-04-25 11:21:29 +02:00
Laurent Monin
8deddf772d Use PluginPriority.HIGH and rename weight to priority 2014-04-24 21:45:11 +02:00
Sophist
4724e73015 Set default weights to 100...
and plugin weight to 200.
2014-04-24 09:55:54 +01:00
Laurent Monin
60fc6e4499 Add weight parameter to metadata_processors
Processors having more weight will be run first, default weight is 0.
2014-04-24 09:55:52 +01:00
Sophist
f1d3e2b46e Add Standardise Performers plugin 2014-04-24 09:55:02 +01:00
Sophist
6818e3451c Handle multiple websites 2014-04-22 18:20:34 +01:00
Sophist
6aea5be41b Increment version no. 2014-04-21 12:10:41 +01:00
Sophist
fe88b779e1 Switch albumartist_website to XmlNode
Resolves PICARD-593.

Fixes issue with #275 when run from Picard executable under Windows.
2014-04-21 12:10:39 +01:00
Sophist
eebf7f46ff Move swapprefix to Picard proper...
... and add similar delprefix
2014-04-18 15:41:42 +01:00
Laurent Monin
5b0e1395cb Merge branch 'Sophist-UK-sophist_add_album_artist_website_plugin' 2014-04-16 16:34:12 +02:00
Laurent Monin
28d6bf90ec Merge branch 'sophist_add_album_artist_website_plugin' of git://github.com/Sophist-UK/picard into Sophist-UK-sophist_add_album_artist_website_plugin
Conflicts:
	NEWS.txt
2014-04-16 16:30:31 +02:00
Laurent Monin
4cc5cd064c Merge pull request #260 from Sophist-UK/sophist_add_view_variables_plugin
Add View Variables plugin
2014-04-16 16:19:11 +02:00
Wieland Hoffmann
33e67fa2d6 Merge branch 'plugin-addtracktomb' of https://github.com/Freso/picard 2014-04-11 14:12:53 +02:00
Frederik "Freso" S. Olesen
8bca1ecfbb addrelease.py: Use approximated "~length" for Recordings.
Recordings don't support sub-second time precision, so the
track.metadata.length used for the two Add...AsRelease classes will
cause an error on /recording/create's "length" field.
track.metadata["~length"] contains the time converted to mm:ss format
and will not cause the error on /recording/create, so this commit
changes AddFileAsRecording to use that.
2014-04-08 21:55:12 +02:00
Frederik "Freso" S. Olesen
b765452aac addrelease.py: Define form_values in __init__().
See https://github.com/musicbrainz/picard/pull/271/files#r11352974
2014-04-07 23:00:54 +02:00
Laurent Monin
865722cbe1 Regenerate .py files from corresponding .ui files 2014-04-07 16:48:31 +02:00
Frederik "Freso" S. Olesen
464aa50298 addrelease.py: Revert change to PLUGIN_NAME.
Per nikki's comment on pull request #271:
https://github.com/musicbrainz/picard/pull/271#discussion_r11242854
2014-04-05 13:17:01 +02:00
Sophist
97d6250452 Handle album finalisation correctly. 2014-04-04 19:05:05 +01:00
Sophist
08444f4d62 Minor tweak to display if variable is null string 2014-04-04 18:32:59 +01:00
Sophist
60bfe8d845 Remove unneeded imports 2014-04-03 11:05:32 +01:00
Sophist
6d76c0b7cf Add Album Artist Website plugin - see PICARD-26
Adds a plugin to get the artist homepage MB relationship and insert into
website (ID3 WOAR tag).

Note: I used this plugin as a trial for using a Picard xml module to
handle MB WS2 xml response. See PICARD-581.
2014-04-03 10:24:33 +01:00
Frederik "Freso" S. Olesen
77af0591b0 addrelease.py: Improve PEP8 compliance (E701).
Fixing instance of error E701: multiple statements on one line (colon).
2014-04-02 17:57:03 +02:00
Frederik "Freso" S. Olesen
bf0fab7f3d addrelease.py: Update plugin metadata.
- Add Freso to PLUGIN_AUTHOR
- Update PLUGIN_NAME and _DESCRIPTION to describe added file
  functionality.
- Increment PLUGIN_VERSION to 0.5.
2014-04-02 17:50:32 +02:00
Frederik "Freso" S. Olesen
ddcf02b339 addrelease.py: Add AddFileAsRelease class.
Allows for easily adding single files (which can't be clustered) as releases.
2014-04-02 17:44:48 +02:00
Frederik "Freso" S. Olesen
eaa5474445 addrelease.py: Add AddFileAsRecording class.
Allows for easily adding individual files as standalone recordings.
2014-04-02 17:22:41 +02:00
Frederik "Freso" S. Olesen
713061b82f addrelease.py: Abstract out submission URL. 2014-04-02 17:20:24 +02:00
Frederik "Freso" S. Olesen
060f2a3812 addrelease.py: Abstract .callback() to parent class.
Child classes now just need to define object type, NAME, and the
set_form_values() method - and reigster_*_action.
2014-04-02 16:36:40 +02:00
Frederik "Freso" S. Olesen
fe06a50369 addrelease.py: Refactor AddClusterAsRelease.
Abstract out some of the functionality all clumped together in
AddClusterAsRelease.callback() to methods of new parent class
AddObjectAsEntity.
2014-04-02 16:13:13 +02:00
Sophist
0fcf46c9bf Fix display of multi-value for id3v23 2014-03-31 21:02:33 +01:00
Sophist
3731ba833f Show multi-value variables as lists. 2014-03-29 15:27:38 +00:00
DanMan
af693808d7 Store ReplayGain info for MP3s in ID3v2 instead of APE tags (supported for years now) 2014-03-28 21:21:06 +01:00
Sophist
0688daa8bb Show variables for tracks without files 2014-03-28 14:07:13 +00:00
Sophist
fabd16b62c Remove unneeded import of track. 2014-03-26 12:28:09 +00:00
Sophist
a850c0133f Handle pre/post #261 2014-03-26 12:21:10 +00:00
Sophist
90b4aec592 Add View Variables plugin 2014-03-26 11:03:22 +00:00