Commit Graph

7535 Commits

Author SHA1 Message Date
Philipp Wolfer
7a42a9cdcc Merge pull request #1243 from phw/context-sensitive-help
PICARD-1576: Context sensitive help
2019-08-20 18:55:24 +02:00
Philipp Wolfer
88df4e033a Merge pull request #1244 from phw/PICARD-1488-improved-progress-slider
PICARD-1488: Player with improved progress slider
2019-08-20 18:54:27 +02:00
Philipp Wolfer
615deeb873 PICARD-1488: Player: Allow jumping to playback position with single click
This modifies the playback position slider in the player toolbar to be directly clickable and jump to the desired playback position.
2019-08-20 16:41:00 +02:00
Philipp Wolfer
be03db8c3b PICARD-1488: Refactored player progress slider into own widget class 2019-08-20 15:45:43 +02:00
Philipp Wolfer
c03f384e5a PICARD-1575: Parse cover art URL from dropped HTML as fallback 2019-08-20 12:12:57 +02:00
Philipp Wolfer
dd6e76d1c4 PICARD-1579: Use dropped cover art binary data as fallback if URL loading fails
When binary image data is received with a drop event, as e.g. Google Chrome does it on Linux, we use this as fallback data if loading the image from URL fails.

Fixes cover art drop from Google image search in Chrome on Linux resulting in small preview file being used instead of full image.
2019-08-20 12:12:57 +02:00
Philipp Wolfer
3d1f14cd35 Better names for cover art provider option pages
Improves linking to the anchors on the Picard website options help page
2019-08-20 08:42:56 +02:00
Philipp Wolfer
aa5cd04ca9 Open options help docs context sensitive 2019-08-20 08:42:56 +02:00
Philipp Wolfer
a4c2e74bb1 Merge pull request #1241 from phw/windows-package-avoid-qt-libs-copy
Load Qt SSL DLLs on Windows directly from Qt install location
2019-08-19 13:56:53 +02:00
Philipp Wolfer
ee32c5b6eb picard.spec: Use os_name variable instead of repeated platform.system() 2019-08-19 08:44:08 +02:00
Philipp Wolfer
10e17386a2 Load Qt SSL DLLs on Windows directly from Qt install location
With this the developer is no longer required to copy those files manually for packaging
2019-08-19 08:33:22 +02:00
Philipp Wolfer
a6b7722d5b gitignore Windows "Zone.Identifier" files 2019-08-19 08:11:39 +02:00
Philipp Wolfer
7a36ad9fb9 PICARD-1575: Handle request errors on cover art drag and drop 2019-08-18 19:00:07 +02:00
Philipp Wolfer
fae4825630 Fixed Qt SSL packaging on Windows 2019-08-18 16:39:07 +02:00
Philipp Wolfer
3285876fe8 Removed unused code line 2019-08-18 15:03:10 +02:00
Philipp Wolfer
39fe6a9236 Merge pull request #1231 from phw/PICARD-1488-improved-media-player-controls
PICARD-1488: Improved media player controls
2019-08-18 08:16:36 +02:00
Philipp Wolfer
505f1e2749 Fix launching on Windows
PyQt5 5.12.3 and later rely on PATH for finding the Qt5 DLLs. Also importing picard.const.sys already pulls in PyQt5 and other dependencies which should not happen this early in the startup.
2019-08-18 08:15:48 +02:00
Philipp Wolfer
997cdaa6e3 Merge pull request #1236 from phw/pep8-flake8
PEP8 fixes, check with flake8
2019-08-18 08:14:07 +02:00
Philipp Wolfer
f4ae01c051 Merge pull request #1237 from phw/PICARD-1575
PICARD-1575: Fixes for cover art drag and drop from browser
2019-08-16 11:02:11 +02:00
Philipp Wolfer
356df2144a PICARD-1575: Handle mime type with charset on cover art drop 2019-08-16 09:28:07 +02:00
Philipp Wolfer
282d73b414 travisci: Prevent py.test running tests of pip installed packages
On macOS builds py.test was also running the tests of packages installed via pip in virtualenv.
2019-08-15 23:54:48 +02:00
Philipp Wolfer
92be69aef5 PICARD-1575: Allow dragging images from Bing image search result 2019-08-15 23:24:46 +02:00
Philipp Wolfer
7548c20e0c PICARD-1575: Accept dropped images with mime type "binary/data"
Some online image sources don't return a proper mime type for images but instead "binary/data" or "application/octet-stream". Try to detect the mime type in this case.
2019-08-15 23:17:08 +02:00
Philipp Wolfer
7481d9ccef Structured .gitignore, added code coverage generated files 2019-08-15 21:57:17 +02:00
Philipp Wolfer
dd329da30a Add Code of Conduct (pointing to MetaBrainz CoC)
Based on the CODE_OF_CONDUCT.md for picard-website project.
2019-08-15 21:11:15 +02:00
Philipp Wolfer
161ed31865 travisci: Use apt addon instead of manually calling apt-get 2019-08-15 21:08:55 +02:00
Philipp Wolfer
790c0301ad CI: Run flake8 on source files in picard/ 2019-08-15 15:10:35 +02:00
Philipp Wolfer
683bcb499f PEP8 fixes, allows for successful check with flake8
Ignore some additional checks globally that don't make much sense for our current code.
2019-08-15 15:10:35 +02:00
Philipp Wolfer
1349aca8aa Merge pull request #1233 from mfmeulenbelt/dutchinstaller
Dutch translation of the Picard Windows installer
2019-08-15 12:20:42 +02:00
mfmeulenbelt
9ad3db2da5 Update Dutch.nsh
Apologies, the translation wasn’t good enough yet and I have updated it.
2019-08-15 11:35:16 +02:00
mfmeulenbelt
dd08255ca8 Added Dutch translation of the Picard-specific bits in the installer. 2019-08-15 11:30:09 +02:00
Philipp Wolfer
cdaf812587 PICARD-1573: Metadata.apply_func() must handle tags getting removed 2019-08-14 18:59:55 +02:00
Philipp Wolfer
3474ece31e Updated pre-commit hook in CONTRIBUTING.md
Added ignore list for files not to check with isort, as isort ignores the configured ignore list when files are passed explicitly.
2019-08-14 17:05:48 +02:00
Philipp Wolfer
f361687fb4 PICARD-1488: Removed unnecessary lambda in playertoolbar 2019-08-14 15:57:03 +02:00
Philipp Wolfer
2095391f85 PICARD-1488: Store logarithmic volume for player
Prevents runding issues, where after restarting the volume UI would show a different value to what was originally set by the user.
2019-08-14 08:42:24 +02:00
Philipp Wolfer
bd5da8fe45 PICARD-1488: Moved set_playback_rate to Player class 2019-08-14 08:29:41 +02:00
Philipp Wolfer
154f5b94e4 Add shebang to upload.sh 2019-08-13 17:58:18 +02:00
Philipp Wolfer
164c32ff01 Picard-1488: playertoolbar code cleanup 2019-08-13 17:42:34 +02:00
Philipp Wolfer
2a9e664872 PICARD-1488: Player toolbar popover position based on toolbar location
When toolbar is docked at top show popovers below the toolbar, if docked on bottom show them above.
2019-08-13 17:42:34 +02:00
Philipp Wolfer
6a8d26ddb3 PICARD-1488: Ensure player popovers are on screen 2019-08-13 17:42:34 +02:00
Philipp Wolfer
ad055f3230 PICARD-1488: Custom icons for play toolbar 2019-08-13 17:42:34 +02:00
Philipp Wolfer
6e8b07407a PICARD-1488: Fix player volume and speed not being set on start 2019-08-13 17:42:34 +02:00
Philipp Wolfer
8da6879eff PICARD-1488: Avoid widget resizes on label changes
Try setting optimal minimum width for variable labels.
2019-08-13 17:42:34 +02:00
Philipp Wolfer
52d0975ef7 PICARD-1488: Shorten media name if it does not fit 2019-08-13 17:42:34 +02:00
Philipp Wolfer
eb620bc759 PICARD-1488: Use SliderPopover for volume control 2019-08-13 17:42:34 +02:00
Philipp Wolfer
a61c2a43f8 PICARD-1488: Generalized SliderPopover implementation 2019-08-13 17:42:34 +02:00
Philipp Wolfer
b9935b3be0 PICARD-1488: Allow setting playback speed with mouse wheel 2019-08-13 17:42:34 +02:00
Philipp Wolfer
1dc5703899 PICARD-1488: Allow player toolbar only on top, bottom and floating.
Placement at the sides with the current layout does not work well, this requires a special handling of vertical layouts.
2019-08-13 17:42:34 +02:00
Philipp Wolfer
208ae62534 PICARD-1488: Update playback speed during playback 2019-08-13 17:42:34 +02:00
Philipp Wolfer
6bcc612a39 PICARD-1488: Playback speed controls 2019-08-13 17:42:34 +02:00