Commit Graph

7535 Commits

Author SHA1 Message Date
Philipp Wolfer
9abd145914 Release 2.4.1 2020-08-11 11:28:45 +02:00
Philipp Wolfer
ae3bc719ca Bump version to 2.4.1dev1 2020-08-11 08:57:46 +02:00
Gabriel Ferreira
38c9e6376c Fix Dark theme checks for older Windows releases 2020-08-11 08:42:36 +02:00
Philipp Wolfer
8eae191062 Release 2.4 2020-08-10 14:10:52 +02:00
Philipp Wolfer
6e901659ea Updated translations from Transifex 2020-08-10 10:50:48 +02:00
Philipp Wolfer
a709279107 Cleaned up TaggerScriptSyntaxHighlighter code 2020-08-06 23:27:49 +02:00
Philipp Wolfer
5835c91b1f PICARD-1902: Fixed script syntax highlighter crash
Fixed Picard crashing when entering "$noop(\)" as a script.
2020-08-06 23:27:49 +02:00
Philipp Wolfer
f113807f31 Support python-dateutil 3.7
dateutil < 3.8.1 will throw ValueError, and not the derived ParseError. For compatibility with existing Linux distros.
2020-08-01 17:43:39 +02:00
Philipp Wolfer
db1b8c1333 PICARD-1896: Fixed mapping "instrument arranger" to arranger tag
See also https://tickets.metabrainz.org/browse/STYLE-217 for the change from "instrumentator" to "instrument arranger".
2020-08-01 15:04:59 +02:00
Philipp Wolfer
d5728772d7 Merge pull request #1580 from Gabrielcarvfer/PICARD-1866
PICARD-1866: Update metadatabox if a single file/cluster/track/album metadata changes.
2020-08-01 13:53:16 +02:00
Philipp Wolfer
40a13ce7f4 PICARD-1878: Upgrade to mutagen 1.45.1 to fix slow saving
mutagen 1.45.1 disables use of nmap to modify files, which resulted in inefficient saving performance on some file systems and network shares.
2020-07-31 17:26:41 +02:00
Laurent Monin
9aaa5c62a8 Merge pull request #1596 from zas/fix_pr_1891
PICARD-1891: handle incorrect date parsing exceptions
2020-07-21 13:19:24 +02:00
Laurent Monin
5e5535a21b Test for ID3 date format 2020-07-21 09:39:21 +02:00
Laurent Monin
4f592a80ab Drop log and simplify exception catching 2020-07-21 09:38:48 +02:00
Philipp Wolfer
615426449f PICARD-1894: Fix tracknumber detection from filename
Do not detect parts of longer numbers as track no., e.g. "Song 2015" must not be detected as track no. 15.
2020-07-21 09:37:24 +02:00
Laurent Monin
219b734569 PICARD-1891: handle incorrect date parsing exceptions
- catch exceptions in extract_year_from_date() and log them to debug
- return None if year cannot be extracted
- check for None in metadata.compare_to_release_parts() before trying to compare years

This isn't perfect, the function is called a lot of time and it spams debug log (if enabled)

Note: I removed a very old comment in imports that doesn't make any sense (it was introduced 6 years ago in 323d12892c) and it was making isort unhappy.
2020-07-20 17:41:46 +02:00
Philipp Wolfer
dd2acaf6ee PICARD-1892: Fixed deleting totaldiscs / totaltracks from Vorbis tags
Deleting failed if the file only contained disctotal or tracktotal tags, but not also totaldiscs or totaltracks.
2020-07-20 13:29:54 +02:00
Philipp Wolfer
048651fa41 Refactor script module into package 2020-07-19 21:30:56 +02:00
Laurent Monin
14db5dcbc3 Merge pull request #1593 from zas/fix_color_saving
PICARD-1890: Fix spurious Restart Picard message about color changes
2020-07-19 21:07:03 +02:00
Laurent Monin
dc782a6b43 Fix spurious Restart Picard message about color changes
- detection of color changes was broken
- code cleanup
- added tests
2020-07-19 16:10:26 +02:00
Philipp Wolfer
a6ecd38ee2 Merge pull request #1591 from dukeyin/picard-1889
PICARD-1889: Don't use release relationships if "Use release relationships" is disabled
2020-07-18 12:47:55 +02:00
Philipp Wolfer
cba7de3c73 PICARD-1763: Ensure macOS working dir is not the app dir\n\nAvoids crashes on startup 2020-07-18 12:46:34 +02:00
dukeyin
cbc1bce030 Add unit test for "Use release relationships"
* Added a release-level producer to release.json because the existing release-artist relationships are not used in tagging
* Modified the existing release test to check that the producer tag is the release-level producer when "Use release relationships" is enabled
* Added a release test to check that the producer tag is empty when "Use release relationships" is disabled
2020-07-17 20:01:37 -04:00
dukeyin
f042928433 Don't use release relationships if they are disabled in metadata options 2020-07-17 19:57:37 -04:00
Philipp Wolfer
079808663c theme: Refactor getting link color with lightness of 160 2020-07-17 14:27:39 +02:00
Philipp Wolfer
c570ae6409 PICARD-1887: Detect use of macOS dark mode
This allows setting the proper dark syntax theme.
2020-07-17 14:25:50 +02:00
Philipp Wolfer
af3b5bdb8f Use working link to RIFF tag docs 2020-07-15 18:24:21 +02:00
Gabriel Ferreira
74719d36da Change inactive highlight text colors if dark inactive highlight color 2020-07-15 08:58:10 +00:00
Gabriel Ferreira
dcb279b97d Increase contrast between focused and unfocused highlighted items 2020-07-15 08:58:10 +00:00
Philipp Wolfer
3dafff556d Update picard.pot 2020-07-14 19:06:11 +02:00
Philipp Wolfer
9c544696b8 Update picard.pot 2020-07-14 19:05:04 +02:00
Philipp Wolfer
98b0f327b2 PICARD-1871: Use TagListEditor for preserved tags 2020-07-14 17:04:51 +00:00
Philipp Wolfer
3f9ad5a743 PICARD-1884: Fix tracknumber tag with value 0 not set 2020-07-14 17:03:30 +00:00
Philipp Wolfer
0cfe332395 PICARD-1881: Use scripting syntax function color for script docs
Instead of having a separate configurable color use the color from the syntax theme.
2020-07-14 07:48:48 +00:00
Philipp Wolfer
bbc3f1450f PICARD-1839: Support tagging DSDIFF (DFF) files with ID3 2020-07-14 07:41:15 +00:00
Philipp Wolfer
92dbb3dd87 PICARD-1873: Fix ugly font rendering in script docs on Windows
Rely on default font definitions, but use the system specific monospace font for code.
2020-07-13 18:13:05 +00:00
Philipp Wolfer
8440bda300 PICARD-1880: Use Consolas font on Windows for Monospace fonts 2020-07-13 18:13:05 +00:00
Philipp Wolfer
0538a5d397 PICARD-1875: Improve function documentation for $firstalphachar 2020-07-13 17:44:12 +00:00
Philipp Wolfer
08884bc37b Fixed required isort version 2020-07-13 17:07:21 +02:00
Philipp Wolfer
0c2f17e6c6 Use mutagen 1.45 for macOS and Win builds 2020-07-13 15:05:08 +00:00
Gabriel Ferreira
797f067efe Cache single album tests for selection 2020-07-07 13:00:59 -03:00
Gabriel Ferreira
6ef6679f65 Update metadatabox if a single file/track/album metadata changes. 2020-07-06 15:34:13 -03:00
Philipp Wolfer
d16128e7a8 Fixed changelog.
PICARD-1869 was not actually a bug and was hence not fixed
2020-07-05 19:34:10 +02:00
Philipp Wolfer
9992fa73bc Release 2.4.0b2 2020-07-05 19:20:09 +02:00
Philipp Wolfer
04a301d8ec Update translations 2020-07-05 19:19:49 +02:00
Philipp Wolfer
ab679c0d60 Fix tests 2020-07-05 19:14:16 +02:00
Philipp Wolfer
2e10534caf Use isort<5 2020-07-05 19:03:13 +02:00
Gabriel Ferreira
83cd6ac363 PICARD-1866: Restore cheaper update_selection
Reenable cheaper version of MainWindow.update_selection for item updates
2020-07-05 12:39:57 +00:00
Philipp Wolfer
d01b33eb5d Merge pull request #1576 from phw/PICARD-1867-repair-guess-format
PICARD-1867: Fix guess_format fallback on file load error
2020-07-03 17:28:34 +00:00
Philipp Wolfer
c303343892 Fixed file loading pending counter not decrementing
If a file was detected as an supported file type, but could not be loaded and had an unsupported file extension, tagger._pending_files_count did not get decremented. This results in table sorting staying disabled.
2020-07-03 16:08:32 +02:00