Sophist
303cf79390
Use assertScriptResultEquals...
...
... instead of assertEqual(self.parser.eval
2017-05-03 09:09:27 +01:00
Wieland Hoffmann
2884f9543d
Merge pull request #714 from mineo/reject-kwonly
...
Reject functions with required keyword-only arguments
2017-05-01 18:36:04 +02:00
Wieland Hoffmann
05b343a232
Reject functions with required keyword-only arguments
...
Python 3 / PEP3102 introduced keyword-only arguments, like in
def foo(a, *, b):
pass
where `b` can't be set as a positional argument. This can't be expressed in
tagger script, so reject calls to register such functions.
This also gets rid of a DeprecationWarning for inspect.getargspec.
Signed-off-by: Wieland Hoffmann <themineo@gmail.com >
2017-05-01 18:27:07 +02:00
Sambhav Kothari
cdc552afb2
Merge pull request #712 from samj1912/picard1077
...
PICARD-1077: Fix update encoding logic on id3 version change
2017-05-01 20:12:05 +05:30
Sambhav Kothari
c54cd694c4
PICARD-1077: Fix update encoding logic on id3 version change
...
Fixes https://tickets.metabrainz.org/browse/PICARD-1077
2017-05-01 19:31:00 +05:30
Sambhav Kothari
fce8155dbc
Merge pull request #715 from mineo/patch-version-default
...
patch_version: Use sys.platform as the default platform name
2017-05-01 19:30:21 +05:30
Sophist
9bb4802144
Add explanatory comments
2017-05-01 13:50:35 +01:00
Sophist
f4ce8e2ca6
Add tests for override with standard sep
2017-05-01 13:44:33 +01:00
Sophist
fca5061a11
Add seperator override tests for $lenmulti
2017-05-01 13:36:29 +01:00
Wieland Hoffmann
399993fef2
patch_version: Use sys.platform as the default platform name
...
The names which sys.platform uses are not well-known across all users (darwin
for macOS for example), so this doesn't change the values used in the packaging
scripts.
2017-05-01 14:32:07 +02:00
Sophist
64e3c89180
Fix bug with default separator overridden.
2017-05-01 13:28:56 +01:00
Sambhav Kothari
e6fcbc077e
Merge pull request #713 from samj1912/remove_unicode
...
Remove unneeded unicode prefix
2017-05-01 16:18:36 +05:30
Sambhav Kothari
33edfd33e6
Fix setup.py update_constants to not include unicode prefix
2017-04-30 19:12:18 +05:30
Sambhav Kothari
6ef1a565c6
Remove unneeded unicode prefix
2017-04-30 18:51:34 +05:30
Sophist
764dacd6a2
Simplify copymerge
2017-04-30 12:59:09 +01:00
Sophist
325c7b403b
Move multi-value code into worker function
2017-04-30 12:55:14 +01:00
Sophist
a763a6ce31
Use existing behaviour if user overrides separator
2017-04-29 21:26:49 +01:00
Sophist
23087cf8c3
Python3 strings are all unicode
2017-04-29 14:01:50 +01:00
Sophist
602dfbb36e
Add $lenmulti function
2017-04-29 14:01:50 +01:00
Sophist
60983a2a22
Fix copymerge
...
1. Newsvals deduped
2. Oldvals in original sequence
2017-04-29 14:01:50 +01:00
Sophist
f2e855771c
Clarify docstring
2017-04-29 14:01:49 +01:00
Sophist
0b4b14ce9c
Fix $inmulti as per #623
2017-04-29 14:01:22 +01:00
Sophist
6474915c00
Remove unneeded imports, refactor code.
2017-04-27 12:26:08 +01:00
Sophist
1112ea432c
Add unit testsfor Metadata object variables
2017-04-26 22:53:57 +01:00
Sambhav Kothari
dd0da64ced
Merge pull request #707 from Sophist-UK/fix-apply_func-2
...
PICARD-1070: 2.0 Make apply_func work on all metadata
2017-04-25 16:05:20 +05:30
Sophist
43b6bffca8
Make apply_func work on all metadata
...
apply_func currently only used for ascii translation in track.py and
album.py.
2017-04-25 15:58:29 +05:30
Sambhav Kothari
35d88d4897
Merge pull request #708 from zas/picard-1073
...
PICARD-1073: cast dict_keys to list, fixing unsupported operand type …
2017-04-23 19:07:13 +05:30
Laurent Monin
2348db7ec9
PICARD-1073: cast dict_keys to list, fixing unsupported operand type error
...
https://tickets.metabrainz.org/browse/PICARD-1073
2017-04-23 14:02:33 +02:00
Wieland Hoffmann
a841fe08c4
Merge pull request #675 from mineo/picard-1052
...
PICARD-1052: Only enable search for similar tracks if the selection contains objects
2017-04-21 23:04:12 +02:00
Wieland Hoffmann
9e02049644
update_actions: Use bool(sequence) for testing emptyness
2017-04-21 22:59:12 +02:00
Wieland Hoffmann
bcfcbe68e8
PICARD-1052: Only enable search for similar tracks if the selection contains objects
2017-04-21 22:59:12 +02:00
Laurent Monin
275e19cc20
Merge pull request #704 from mineo/scripttest-function
...
Move the self.assertEqual(self.parser.eval(...), ...) pattern to a function
2017-04-17 21:28:57 +02:00
Laurent Monin
ed3a9c3687
Merge pull request #705 from mineo/travis-fork-tx
...
Don't run steps involving transifex if credentials are not available
2017-04-17 21:28:42 +02:00
Wieland Hoffmann
25498c1a93
Don't run steps involving transifex if credentials are not available
...
I have activated travis for my fork of picard and get emails about builds
failing because this step fails.
2017-04-17 18:53:40 +02:00
Wieland Hoffmann
a749e996e7
Remove unused imports
2017-04-17 18:14:46 +02:00
Wieland Hoffmann
06dd81b78e
Move the self.assertEqual(self.parser.eval(...), ...) pattern to a function
2017-04-17 18:14:20 +02:00
Sambhav Kothari
c18db063b5
Merge pull request #694 from samj1912/picard1062
...
PICARD-1062: Sort results by similarity
2017-04-17 02:50:59 +05:30
Sambhav Kothari
69b8522864
PICARD-1062: Sort results by similarity (first member of tuple match)
2017-04-17 02:43:48 +05:30
Laurent Monin
47ada573ab
Merge pull request #702 from samj1912/more_tests
...
Add distutil testing to travis
2017-04-15 17:54:55 +02:00
Laurent Monin
6d3c008760
Merge pull request #703 from samj1912/updatetov2
...
Update API end point to v2
2017-04-15 17:48:59 +02:00
Sambhav Kothari
b2c865ad0d
Update API end point to v2
2017-04-13 18:26:44 +05:30
Sambhav Kothari
dd4d3e0994
Add distutil testing to travis
2017-04-13 16:39:34 +05:30
Laurent Monin
7a84879040
Merge pull request #701 from mineo/astrcmp-wording
...
test_astrcmp: Rephrase the skip message to not refer to a not existing file
2017-04-11 19:32:12 +02:00
Wieland Hoffmann
896b62a3b5
test_astrcmp: Rephrase the skip message to not refer to a not existing file
2017-04-11 19:03:34 +02:00
Wieland Hoffmann
fb89d5e93c
Remove unused imports
2017-04-11 19:00:32 +02:00
Laurent Monin
be5e172f52
Merge pull request #699 from samj1912/picard1065
...
PICARD-1065: Fix patch_version
2017-04-11 00:26:32 +02:00
Laurent Monin
2b0ef89653
Merge pull request #698 from samj1912/picard1066
...
PICARD-1066: Fix update_constants
2017-04-11 00:25:39 +02:00
Laurent Monin
1906b743f2
Merge pull request #696 from Sophist-UK/PICARD-1063_Fix-astrcmp-tests-if-not-compiled
...
PICARD-1063: Fix astrcmp tests if not compiled
2017-04-11 00:21:44 +02:00
Laurent Monin
be6a4ce703
Merge pull request #697 from samj1912/picard1064
...
PICARD-1064: Fix verbose tests
2017-04-11 00:02:50 +02:00
Sambhav Kothari
3db758f4e0
PICARD-1065: Fix patch_version
2017-04-11 01:35:50 +05:30