Sophist
3df8ff193d
Replace code with that proposed by Zas
2017-01-27 10:06:36 +00:00
Sophist
d5f3ca3665
Use set.add not set.append
2017-01-26 20:42:23 +00:00
Sophist
0eb9b242c2
Use set instead of list
2017-01-26 20:40:42 +00:00
Sophist
0d9b9f08f0
PICARD-950: Don't open same folder multiple times
...
Resolves [PICARD-950](https://tickets.metabrainz.org/browse/PICARD-950 )
This will need rebasing after #598 is merged.
2017-01-26 20:40:41 +00:00
Laurent Monin
bdeea8d6b0
Merge pull request #602 from Freso/update-jira-links
...
Update links to ticket tracker.
2017-01-26 20:26:46 +01:00
Laurent Monin
94cf35a593
Merge pull request #598 from Sophist-UK/patch-1
...
PICARD-942: Fix explore/play remote folders/files
2017-01-26 20:19:07 +01:00
Frederik “Freso” S. Olesen
8789668ea2
Clean up in-line comments in build_qurl().
...
After "refactoring" for PICARD-951, the in-line comments in the
`build_qurl()` provide pretty much no information that isn't readily
readable from the surrounding code.
2017-01-26 19:00:21 +01:00
Lukáš Lalinský
ad5cce79c9
Add docs for building the os x packages
2017-01-26 18:57:45 +01:00
Frederik “Freso” S. Olesen
e85febfd23
Don't check port when contacting musicbrainz.org.
...
If we're always using HTTPS when contacting musicbrainz.org, there's no
reason to check for the port at all, so let's not.
2017-01-26 18:40:25 +01:00
Sophist
97d29c8ef2
Add comment to code referring to Qt bug.
2017-01-26 17:29:45 +00:00
Frederik “Freso” S. Olesen
71bf0fa1a8
Update links to ticket tracker.
...
Using:
`sed -i 's|http://tickets.musicbrainz.org |https://tickets.metabrainz.org |' $(git grep -l tickets.musicbrainz -- './*' ':!*.po')`
2017-01-26 18:19:31 +01:00
Sophist
533f168827
PICARD-953: Show album with extra tracks unmatched
...
Resolves [PICARD-953](https://tickets.metabrainz.org/browse/PICARD-953 ).
If an album has unmatched files ii is shown as incomplete even if all album tracks are matched to one file. Although the terminology would suggest that such an album is "complete", in practical terms the album is not perfect because in all likelihood the user needs to select a different release with more tracks.
2017-01-26 16:36:12 +00:00
Frederik “Freso” S. Olesen
08722cf9ee
PICARD-952: Use HTTPS for Cover Art Archive.
2017-01-26 16:19:16 +01:00
Lukáš Lalinský
b62de843ae
Avoid accessing config.setting on module level
2017-01-26 15:56:19 +01:00
Frederik “Freso” S. Olesen
5924ffd8c9
PICARD-951: Always use HTTPS for musicbrainz.org.
...
MusicBrainz.org is eventually going to go all HTTPS-only, though the
webservice for now can still be reached via HTTP. To help the move to
HTTPS, this commit makes URLs built via `build_qurl()` always use HTTPS
when going to a MusicBrainz server (as defined by the
`MUSICBRAINZ_SERVERS` constant).
This also means that the check in the `build_qurl()` function for
whether a given page/URL is/requires an authentication for MusicBrainz
is now redundant, as we're always using HTTPS on MusicBrainz, regardless
of login/authentication status.
2017-01-26 14:04:23 +01:00
Sophist
a8a96a6bdf
PICARD-942: Fix explore/play remote folders/files
...
Resolves [PICARD-942](https://tickets.metabrainz.org/browse/PICARD-942 ).
Make "Open Containing Folder" and "Open in Player" work for remote files.
See [QTBUG-13359](https://bugreports.qt.io/browse/QTBUG-13359 ) for cause and workaround.
Tested on Windows. Needs testing on Mac / Linux.
2017-01-26 10:44:46 +00:00
Laurent Monin
6d88f091d4
Merge pull request #597 from lalinsky/fix-osx-package
...
Fix OS X package
2017-01-26 08:54:37 +01:00
Laurent Monin
19f98ed860
Merge pull request #596 from samj1912/patch-8
...
Correct the variable naming style and docstring language fix
2017-01-26 08:46:49 +01:00
Lukáš Lalinský
f70b49f0bb
Fix OS X package
...
It seems that if the ini-based config was initialized before creating the app instance,
Qt would do a different initialization sequence and some configs would not be loaded.
That caused it to not look for plugins in the app bundle.
2017-01-25 22:05:55 +01:00
Sambhav Kothari
2ad5936372
Correct the variable naming style
2017-01-26 01:22:03 +05:30
Lukáš Lalinský
979347ddca
Build OS X packages in GitLab
2017-01-25 19:54:17 +01:00
Laurent Monin
2ff74bad2b
Merge pull request #593 from samj1912/patch-7
...
Add python style guide
2017-01-25 18:18:15 +01:00
Sambhav Kothari
5d603c1b18
Add guideline for i18n
2017-01-25 21:37:32 +05:30
Sambhav Kothari
be5eddb0c4
Add picard specific code guidelines to CONTRIBUTING.md
2017-01-25 21:27:01 +05:30
Laurent Monin
9cc69acf25
Merge pull request #595 from Freso/PICARD-945-remove-contrib-warning
...
PICARD-945: Demote non-existent plugin warning to info message.
2017-01-25 12:10:41 +01:00
Frederik “Freso” S. Olesen
47d57a4ebc
PICARD-945: Demote non-existent plugin warning to info message.
...
Instead of presenting as a warning if a given plugin directory isn't
found, just notify as an info-level message.
2017-01-25 12:05:29 +01:00
Laurent Monin
6a316ee1e7
Merge pull request #594 from samj1912/fix519
...
PICARD-946: Fix wrong new_file variable assignement due to modified old_file
2017-01-25 09:32:09 +01:00
Sambhav Kothari
ae73c8c04c
Fix wrong new_file variable assignement due to modified old_file
2017-01-25 13:44:25 +05:30
Laurent Monin
e4a04d37e9
Merge pull request #589 from samj1912/picard933
...
PICARD-944: Wait for save thread pool to be finished before exit
2017-01-25 08:22:32 +01:00
Sambhav Kothari
585d5c4a47
Update CONTRIBUTING.md
2017-01-25 01:25:04 +05:30
Wieland Hoffmann
b7fbae58db
Fix grammar and markup
...
[ci skip]
2017-01-24 18:21:03 +01:00
Sambhav Kothari
14f123d5d4
Remove monkey patching of windows file write methods
2017-01-24 22:38:54 +05:30
Laurent Monin
579390be95
Merge pull request #591 from samj1912/patch-6
...
Create CONTRIBUTING.md
2017-01-24 16:39:22 +01:00
Laurent Monin
54c9faec55
Merge pull request #588 from samj1912/gui2
...
PICARD-937: Clear status bar on selection update
2017-01-24 13:26:31 +01:00
Sambhav Kothari
49fc42244a
Create CONTRIBUTING.md
2017-01-24 17:44:07 +05:30
Sambhav Kothari
ac30c7f919
Wait for save thread pool to be finished before exit
2017-01-23 19:41:35 +05:30
Laurent Monin
b34fb8f377
Update picard.pot
2017-01-23 14:00:36 +01:00
Laurent Monin
0fbea085dc
Update translations
2017-01-23 13:59:39 +01:00
Sambhav Kothari
b83841cbb5
Clear status bar on selection update
2017-01-23 15:33:11 +05:30
Sambhav Kothari
1b157e7abb
Add tooltip for Scan toolbar button
2017-01-23 15:07:30 +05:30
Wieland Hoffmann
06e5e1624d
Add the reason mimetypes is bundled in the Windows installer in a comment
2017-01-20 22:43:57 +01:00
Lukáš Lalinský
142387a21f
Fix windows build
2017-01-20 12:22:51 +01:00
Lukáš Lalinský
6775da3c42
samj1912's change
2017-01-20 12:01:31 +01:00
Lukáš Lalinský
9575151264
Attempt #2
2017-01-20 11:58:17 +01:00
Lukáš Lalinský
999194d13e
Try moving the entire directory
2017-01-20 11:56:29 +01:00
Laurent Monin
984a964969
Merge pull request #584 from samj1912/patch-5
...
Confirm yes to 7z extraction
2017-01-20 11:33:03 +01:00
Sambhav Kothari
ff75974aa3
Update package-win.bat
2017-01-20 16:00:07 +05:30
Laurent Monin
f01625de1d
Merge pull request #581 from samj1912/plugre
...
Change windows packager to download and install latest plugins
2017-01-20 10:40:08 +01:00
Laurent Monin
ab2c9ce16a
Merge pull request #583 from samj1912/patch-2
...
Add mimetypes in py2exe module includes
2017-01-20 10:37:33 +01:00
Sambhav Kothari
459700b212
Add mimetypes in py2exe module includes
2017-01-20 13:58:19 +05:30
