fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-27 18:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,535 Commits 1 Branch 0 Tags
edc3cfddeef6c78dcafe738b970408aa48b35fe9
Commit Graph

7535 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sophist
2f75646389 Switch to using artist rather than artists[0]. 2014-05-14 07:40:05 +01:00
Sophist
db588bc722 Revert "Handle NAT tracks with feat. artists." 
This reverts commit 0707add3353455473f5ff26a117c7843d42cd4d5.
 2014-05-14 07:40:04 +01:00
Sophist
d94187754f Handle NAT tracks with feat. artists. 
Add %_primaryartist% and %_primaryartistsort% and use
%_primaryartist% in default naming string.
 2014-05-14 07:40:02 +01:00
Sophist
1dbafa827a Use getall rather than split by ; (bitmap) 2014-05-14 07:40:01 +01:00
Sophist
4d882bf519 Add NEWS. 2014-05-14 07:40:00 +01:00
Sophist
b749961a2e Remove debug print statement 2014-05-14 07:39:57 +01:00
Sophist
5934ffa805 Add %_multiartist% and fix default renaming. 
See http://forums.musicbrainz.org/viewtopic.php?pid=25318
 2014-05-14 07:39:56 +01:00
Sophist
23577ec837 Make file loading more resilient 
See (PICARD-605)[http://tickets.musicbrainz.org/browse/PICARD-605]
 2014-05-14 07:38:31 +01:00
Laurent Monin
bdaf9e7d89 Add missing whitelines + album_artist_from_path() description 2014-05-13 17:05:01 +02:00
Laurent Monin
7d378f3026 Merge pull request #328 from Sophist-UK/sophist_improve_clustering 
Improve clustering using directory structure if no existing album tags
 2014-05-13 15:28:43 +02:00
Sophist
4daab44b74 Fix typo 2014-05-12 22:28:47 +01:00
Sophist
6344ca2806 Move album_artist_from_path to utils 
and add test.
 2014-05-12 22:24:31 +01:00
Sophist
3cc636b402 Simplify code for readability. 2014-05-12 21:07:37 +01:00
Sophist
cacc4c1419 Remove debug print. 2014-05-12 21:07:35 +01:00
Sophist
cbc3a79205 Tweak to not overwrite artist if it exists 2014-05-12 21:07:34 +01:00
Sophist
87da33bd8e Improve clustering by grouping by directory 2014-05-12 21:07:32 +01:00
Sophist
3e601c06c1 Strip tracknumber from title if leading 2014-05-12 21:07:31 +01:00
Laurent Monin
e7924239c0 Merge pull request #327 from Sophist-UK/sophist_fix_tagstofilenames 
Fix issues in Tags from File Names...
 2014-05-12 14:59:24 +02:00
Laurent Monin
a6ce2047cf Merge pull request #325 from zas/request_delay_fix 
Fix up "Waiting 0 ms before ..." debug message
 2014-05-12 14:57:47 +02:00
Laurent Monin
818af48e25 Merge pull request #324 from zas/add_files_debug_fix 
Fix debug message "Add files <generator object <genexpr> at ..."
 2014-05-12 14:57:11 +02:00
Laurent Monin
f34eb6316d Merge pull request #320 from zas/album.metadata.hack.fix 
Remove the hack modifying album.metadata['album'] for display purpose
 2014-05-12 14:56:45 +02:00
Sophist
9b2bd19f1a Fix issues in Tags from File Names... 
1. Replace all \ with / in path not just last one so it works properly
on Windows.
2. Set combo index to show last used string
3. Strip leading zeros from numeric tags like tracknumber.
 2014-05-12 10:25:02 +01:00
Laurent Monin
6280451464 Fix up "Waiting 0 ms before ..." debug message 
- last_ms has sub-milliseconds precision
- request_delay - last_ms can be < 1.0 (and it is a float)
- message use %d to convert value from float to int (so 0.5 is displayed 0 ms)
- QTimer.start() only supports milliseconds precision as int (so 0.5 will prolly be converted to 0)
- if delay is required, better wait more than not enough, so, ie.,  0.7 ms delay is converted to 1 ms
- when delay is required, 0 delay doesn't make sense, first branch of the if condition handled that
- int(math.ceil(delay)) does the job
- int() cast is needed with python 2 (it returns a float), python 3 math.ceil() returns int
 2014-05-11 14:10:06 +02:00
Laurent Monin
478544f2bb Fix debug message "Add files <generator object <genexpr> at ..." 
Not very useful, replaced by a more useful debug message (later in code, since exclusion of files is already logged)
 2014-05-11 13:29:53 +02:00
Laurent Monin
c2f128c001 Merge pull request #322 from Sophist-UK/sophist_add_tests_windows_drive 
Fix and add tests for windows drive
 2014-05-11 13:18:38 +02:00
Sophist
81544ca38f Fix so this runs correctly under ix with win set. 2014-05-11 11:31:58 +01:00
Sophist
adab289bdb Fix and add tests for windows drive 2014-05-11 10:24:35 +01:00
Laurent Monin
82b4895e98 Merge pull request #321 from Sophist-UK/sophist_improve_76bf791c2a990eebe3b1d7620bd002a5999415b0 
Improve 76bf791
 2014-05-11 10:08:03 +02:00
Sophist
c826639abc Improve 76bf791c2a 
Puts the fix where it really should be in replace_win32_incompat.
 2014-05-11 08:00:19 +01:00
Laurent Monin
b454cc1506 Remove the hack modifying album.metadata['album'] for display purpose 
This hack was leading to cluttered debug messages since __repr__() was returning
status message in place of album's title.

Instead use a `status` property which is displayed in place of the title when it isn't None.
 2014-05-10 22:30:45 +02:00
Laurent Monin
2a4cd9c317 Merge pull request #313 from zas/coverart_cleanup 
Coverart cleanup, mostly code rewrite + minor fixes
 2014-05-10 22:03:52 +02:00
Laurent Monin
60527717ff Merge pull request #318 from Sophist-UK/sophist_refresh_only_obj.can_refresh 
Only refresh objects which can be refreshed
 2014-05-10 21:56:02 +02:00
Laurent Monin
34d02c4027 Merge pull request #319 from Sophist-UK/sophist_fix_cover_art_saves_windows 
Fix conversion of : to _ in drive letter on windows
 2014-05-10 21:55:35 +02:00
Laurent Monin
52afea16d8 Differentiate case of no CAA info vs no cover art 2014-05-10 21:21:13 +02:00
Laurent Monin
ced1d2ac82 has_caa_artwork -> caa_has_suitable_artwork 
It reflects much more its purpose as even if caa has artwork we may have this set to False
 2014-05-10 21:02:35 +02:00
Laurent Monin
7b034087d7 Introduce caa_has_front and caa_has_back, reduce code redundancy 2014-05-10 20:59:52 +02:00
Laurent Monin
8078702741 has_front -> want_front, has_back -> want_back 
Those are defined according to user config option for accepted caa types.
 2014-05-10 20:53:30 +02:00
Sophist
76bf791c2a Fix conversion of : to _ in drive letter on windows 
```
D: 19:02:00 Saving cover images to u'D_\\Audio\\Music\\Pop\\ABBA\\ABBA
(1992) Gold - Greatest Hits\\folder'
E: 19:02:00 Traceback (most recent call last):
File "picard\util\thread.pyo", line 46, in run
File "picard\file.pyo", line 197, in _save_and_rename
File "picard\file.pyo", line 326, in _save_images
File "picard\metadata.pyo", line 143, in save
File "os.pyo", line 150, in makedirs
File "os.pyo", line 150, in makedirs
File "os.pyo", line 150, in makedirs
File "os.pyo", line 150, in makedirs
File "os.pyo", line 150, in makedirs
File "os.pyo", line 157, in makedirs
WindowsError: [Error 5] Access is denied: u'D_'
```
 2014-05-10 19:02:42 +01:00
Sophist
1a13534105 Only refresh objects which can be refreshed 2014-05-10 16:41:47 +01:00
Laurent Monin
5a398062c1 Improve amazon sizes codes description 
Source: http://aaugh.com/imageabuse.html (+ confirmed by my tests)
 2014-05-09 17:58:51 +02:00
Laurent Monin
21590355e1 Fix up incorrect handling of missing image (data < 1000) case 
- just log a warning, it may happen ie. if large amazon's image request failed
- set front_image_found only if no error
 2014-05-09 17:11:29 +02:00
Laurent Monin
7585729455 Use named place holders in AMAZON_IMAGE_PATH 2014-05-09 17:11:29 +02:00
Laurent Monin
af67fd22bd Wrap few long lines and remove spurious space 2014-05-09 15:24:51 +02:00
Laurent Monin
b256b673cd at_least_one_front_image -> front_image_found 2014-05-09 15:23:01 +02:00
Laurent Monin
7a90e8896a CoverArtImage.parse_url(): tidy up 2014-05-09 15:21:10 +02:00
Laurent Monin
e762388a94 Add Copyright line in licence header 2014-05-09 15:19:28 +02:00
Laurent Monin
5ed2a5b81a _download_next_in_queue(): fix up description 2014-05-08 10:54:57 +02:00
Laurent Monin
118bfa8d5c Improve CAA debug messages 2014-05-08 10:16:37 +02:00
Laurent Monin
4f3520e688 CoverArtImage: add __unicode__() and __str__(), improve error/debug messages 2014-05-08 09:46:35 +02:00
Laurent Monin
919150d2a2 CoverArtImage: make url optional at instanciation, improve __repr__() 2014-05-08 09:31:24 +02:00