mirror of
https://github.com/fergalmoran/picard.git
synced 2026-01-06 16:44:06 +00:00
1bcad37f86
- bump Picard version to 2.2.0dev3 and add a hook to convert ignore_genres to genres_filter - modify Genres UI - add a playground to test genre_filter - improve error handling
235 lines
10 KiB
Python
235 lines
10 KiB
Python
# -*- coding: utf-8 -*-
|
|
#
|
|
# Picard, the next-generation MusicBrainz tagger
|
|
# Copyright (C) 2019 Laurent Monin
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
from test.test_config import TestPicardConfigCommon
|
|
|
|
from picard.config import (
|
|
BoolOption,
|
|
IntOption,
|
|
ListOption,
|
|
TextOption,
|
|
)
|
|
from picard.config_upgrade import (
|
|
OLD_DEFAULT_FILE_NAMING_FORMAT,
|
|
upgrade_to_v1_0_0_final_0,
|
|
upgrade_to_v1_3_0_dev_1,
|
|
upgrade_to_v1_3_0_dev_2,
|
|
upgrade_to_v1_3_0_dev_3,
|
|
upgrade_to_v1_3_0_dev_4,
|
|
upgrade_to_v1_4_0_dev_2,
|
|
upgrade_to_v1_4_0_dev_3,
|
|
upgrade_to_v1_4_0_dev_4,
|
|
upgrade_to_v1_4_0_dev_6,
|
|
upgrade_to_v1_4_0_dev_7,
|
|
upgrade_to_v2_0_0_dev_3,
|
|
upgrade_to_v2_1_0_dev_1,
|
|
upgrade_to_v2_2_0_dev_3,
|
|
)
|
|
from picard.const import (
|
|
DEFAULT_FILE_NAMING_FORMAT,
|
|
DEFAULT_NUMBERED_SCRIPT_NAME,
|
|
)
|
|
|
|
|
|
class TestPicardConfigUpgrades(TestPicardConfigCommon):
|
|
|
|
def test_upgrade_to_v1_0_0_final_0_A(self):
|
|
TextOption('setting', 'file_naming_format', '')
|
|
|
|
self.config.setting['va_file_naming_format'] = 'abc'
|
|
self.config.setting['use_va_format'] = True
|
|
|
|
self.assertIn('va_file_naming_format', self.config.setting)
|
|
self.assertIn('use_va_format', self.config.setting)
|
|
|
|
upgrade_to_v1_0_0_final_0(self.config, interactive=False, merge=True)
|
|
self.assertNotIn('va_file_naming_format', self.config.setting)
|
|
self.assertNotIn('use_va_format', self.config.setting)
|
|
self.assertIn('file_naming_format', self.config.setting)
|
|
|
|
def test_upgrade_to_v1_0_0_final_0_B(self):
|
|
TextOption('setting', 'file_naming_format', '')
|
|
|
|
self.config.setting['va_file_naming_format'] = 'abc'
|
|
self.config.setting['use_va_format'] = ""
|
|
|
|
self.assertIn('va_file_naming_format', self.config.setting)
|
|
self.assertIn('use_va_format', self.config.setting)
|
|
|
|
upgrade_to_v1_0_0_final_0(self.config, interactive=False, merge=False)
|
|
self.assertNotIn('va_file_naming_format', self.config.setting)
|
|
self.assertNotIn('use_va_format', self.config.setting)
|
|
self.assertNotIn('file_naming_format', self.config.setting)
|
|
|
|
def test_upgrade_to_v1_3_0_dev_1(self):
|
|
BoolOption('setting', 'windows_compatibility', False)
|
|
|
|
self.config.setting['windows_compatible_filenames'] = True
|
|
upgrade_to_v1_3_0_dev_1(self.config)
|
|
self.assertNotIn('windows_compatible_filenames', self.config.setting)
|
|
self.assertTrue(self.config.setting['windows_compatibility'])
|
|
|
|
def test_upgrade_to_v1_3_0_dev_2(self):
|
|
TextOption('setting', 'preserved_tags', '')
|
|
|
|
self.config.setting['preserved_tags'] = "a b c "
|
|
upgrade_to_v1_3_0_dev_2(self.config)
|
|
self.assertEqual("a,b,c", self.config.setting['preserved_tags'])
|
|
|
|
def test_upgrade_to_v1_3_0_dev_3(self):
|
|
ListOption("setting", "preferred_release_countries", [])
|
|
ListOption("setting", "preferred_release_formats", [])
|
|
ListOption("setting", "enabled_plugins", [])
|
|
ListOption("setting", "caa_image_types", [])
|
|
ListOption("setting", "metadata_box_sizes", [])
|
|
|
|
self.config.setting['preferred_release_countries'] = "a b c"
|
|
self.config.setting['preferred_release_formats'] = "a b c"
|
|
self.config.setting['enabled_plugins'] = 'a b c'
|
|
self.config.setting['caa_image_types'] = 'a b c'
|
|
self.config.setting['metadata_box_sizes'] = 'a b c'
|
|
|
|
upgrade_to_v1_3_0_dev_3(self.config)
|
|
self.assertEqual(["a", "b", "c"], self.config.setting['preferred_release_countries'])
|
|
self.assertEqual(["a", "b", "c"], self.config.setting['preferred_release_formats'])
|
|
self.assertEqual(["a", "b", "c"], self.config.setting['enabled_plugins'])
|
|
self.assertEqual(["a", "b", "c"], self.config.setting['caa_image_types'])
|
|
self.assertEqual(["a", "b", "c"], self.config.setting['metadata_box_sizes'])
|
|
|
|
def test_upgrade_to_v1_3_0_dev_4(self):
|
|
ListOption("setting", "release_type_scores", [])
|
|
|
|
self.config.setting['release_type_scores'] = "a 0.1 b 0.2 c 1"
|
|
upgrade_to_v1_3_0_dev_4(self.config)
|
|
|
|
self.assertEqual([('a', 0.1), ('b', 0.2), ('c', 1.0)], self.config.setting['release_type_scores'])
|
|
|
|
def test_upgrade_to_v1_4_0_dev_2(self):
|
|
self.config.setting['username'] = 'abc'
|
|
self.config.setting['password'] = 'abc' # nosec
|
|
|
|
upgrade_to_v1_4_0_dev_2(self.config)
|
|
self.assertNotIn('username', self.config.setting)
|
|
self.assertNotIn('password', self.config.setting)
|
|
|
|
def test_upgrade_to_v1_4_0_dev_3(self):
|
|
ListOption("setting", "ca_providers", [])
|
|
|
|
self.config.setting['ca_provider_use_amazon'] = True
|
|
self.config.setting['ca_provider_use_caa'] = True
|
|
self.config.setting['ca_provider_use_whitelist'] = False
|
|
self.config.setting['ca_provider_use_caa_release_group_fallback'] = True
|
|
|
|
upgrade_to_v1_4_0_dev_3(self.config)
|
|
self.assertIn('ca_providers', self.config.setting)
|
|
self.assertIn(('Amazon', True), self.config.setting['ca_providers'])
|
|
self.assertIn(('Cover Art Archive', True), self.config.setting['ca_providers'])
|
|
self.assertIn(('Whitelist', False), self.config.setting['ca_providers'])
|
|
self.assertIn(('CaaReleaseGroup', True), self.config.setting['ca_providers'])
|
|
self.assertEqual(len(self.config.setting['ca_providers']), 4)
|
|
|
|
def test_upgrade_to_v1_4_0_dev_4(self):
|
|
TextOption("setting", "file_naming_format", "")
|
|
|
|
self.config.setting['file_naming_format'] = 'xxx'
|
|
upgrade_to_v1_4_0_dev_4(self.config)
|
|
self.assertEqual('xxx', self.config.setting['file_naming_format'])
|
|
|
|
self.config.setting['file_naming_format'] = OLD_DEFAULT_FILE_NAMING_FORMAT
|
|
upgrade_to_v1_4_0_dev_4(self.config)
|
|
self.assertEqual(DEFAULT_FILE_NAMING_FORMAT, self.config.setting['file_naming_format'])
|
|
|
|
def test_upgrade_to_v1_4_0_dev_6(self):
|
|
BoolOption('setting', 'enable_tagger_scripts', False)
|
|
ListOption('setting', 'list_of_scripts', [])
|
|
|
|
self.config.setting['enable_tagger_script'] = True
|
|
self.config.setting['tagger_script'] = "abc"
|
|
upgrade_to_v1_4_0_dev_6(self.config)
|
|
|
|
self.assertNotIn('enable_tagger_script', self.config.setting)
|
|
self.assertNotIn('tagger_script', self.config.setting)
|
|
|
|
self.assertTrue(self.config.setting['enable_tagger_scripts'])
|
|
self.assertEqual([(0, DEFAULT_NUMBERED_SCRIPT_NAME % 1, True, 'abc')], self.config.setting['list_of_scripts'])
|
|
|
|
def test_upgrade_to_v1_4_0_dev_7(self):
|
|
BoolOption('setting', 'embed_only_one_front_image', False)
|
|
|
|
self.config.setting['save_only_front_images_to_tags'] = True
|
|
upgrade_to_v1_4_0_dev_7(self.config)
|
|
self.assertNotIn('save_only_front_images_to_tags', self.config.setting)
|
|
self.assertTrue(self.config.setting['embed_only_one_front_image'])
|
|
|
|
def test_upgrade_to_v2_0_0_dev_3(self):
|
|
IntOption("setting", "caa_image_size", 500)
|
|
|
|
self.config.setting['caa_image_size'] = 0
|
|
upgrade_to_v2_0_0_dev_3(self.config)
|
|
self.assertEqual(250, self.config.setting['caa_image_size'])
|
|
|
|
self.config.setting['caa_image_size'] = 501
|
|
upgrade_to_v2_0_0_dev_3(self.config)
|
|
self.assertEqual(501, self.config.setting['caa_image_size'])
|
|
|
|
def test_upgrade_to_v2_1_0_dev_1(self):
|
|
BoolOption("setting", "use_genres", False)
|
|
IntOption("setting", "max_genres", 5)
|
|
IntOption("setting", "min_genre_usage", 90)
|
|
TextOption("setting", "ignore_genres", "seen live, favorites, fixme, owned")
|
|
TextOption("setting", "join_genres", "")
|
|
BoolOption("setting", "only_my_genres", False)
|
|
BoolOption("setting", "artists_genres", False)
|
|
BoolOption("setting", "folksonomy_tags", False)
|
|
|
|
self.config.setting['folksonomy_tags'] = True
|
|
self.config.setting['max_tags'] = 6
|
|
self.config.setting['min_tag_usage'] = 85
|
|
self.config.setting['ignore_tags'] = "abc"
|
|
self.config.setting['join_tags'] = "abc"
|
|
self.config.setting['only_my_tags'] = True
|
|
self.config.setting['artists_tags'] = True
|
|
|
|
upgrade_to_v2_1_0_dev_1(self.config)
|
|
self.assertEqual(self.config.setting['use_genres'], True)
|
|
self.assertEqual(self.config.setting['max_genres'], 6)
|
|
self.assertEqual(self.config.setting['min_genre_usage'], 85)
|
|
self.assertEqual(self.config.setting['ignore_genres'], "abc")
|
|
self.assertEqual(self.config.setting['join_genres'], "abc")
|
|
self.assertEqual(self.config.setting['only_my_genres'], True)
|
|
self.assertEqual(self.config.setting['artists_genres'], True)
|
|
|
|
self.assertIn('folksonomy_tags', self.config.setting)
|
|
|
|
self.assertNotIn('max_tags', self.config.setting)
|
|
self.assertNotIn('min_tag_usage', self.config.setting)
|
|
self.assertNotIn('ignore_tags', self.config.setting)
|
|
self.assertNotIn('join_tags', self.config.setting)
|
|
self.assertNotIn('only_my_tags', self.config.setting)
|
|
self.assertNotIn('artists_tags', self.config.setting)
|
|
|
|
def test_upgrade_to_v2_2_0_dev_3(self):
|
|
TextOption("setting", "ignore_genres", "")
|
|
TextOption("setting", "genres_filter", "")
|
|
|
|
self.config.setting['ignore_genres'] = "a, b,c"
|
|
upgrade_to_v2_2_0_dev_3(self.config)
|
|
self.assertNotIn('ignore_genres', self.config.setting)
|
|
self.assertEqual(self.config.setting['genres_filter'], "-a\n-b\n-c")
|