From 3fc19ea77bdbf09d764c2116eab20a32fe1f34eb Mon Sep 17 00:00:00 2001 From: SteveSandersonMS Date: Tue, 14 Jun 2016 10:16:40 +0100 Subject: [PATCH] Add missing lock to ensure thread-safe mutations of _activeInnerStreams in VirtualConnectionClient.cs --- .../VirtualConnections/VirtualConnectionClient.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.AspNetCore.NodeServices/HostingModels/VirtualConnections/VirtualConnectionClient.cs b/src/Microsoft.AspNetCore.NodeServices/HostingModels/VirtualConnections/VirtualConnectionClient.cs index 9f34303..f5e2d62 100644 --- a/src/Microsoft.AspNetCore.NodeServices/HostingModels/VirtualConnections/VirtualConnectionClient.cs +++ b/src/Microsoft.AspNetCore.NodeServices/HostingModels/VirtualConnections/VirtualConnectionClient.cs @@ -46,7 +46,11 @@ namespace Microsoft.AspNetCore.NodeServices.HostingModels.VirtualConnections var id = Interlocked.Increment(ref _nextInnerStreamId); var newInnerStream = new VirtualConnection(id, this); - _activeInnerStreams.Add(id, newInnerStream); + lock (_activeInnerStreams) + { + _activeInnerStreams.Add(id, newInnerStream); + } + return newInnerStream; }