github/JavaScriptServices
1
1
Fork 0
mirror of https://github.com/aspnet/JavaScriptServices.git synced 2025-12-22 17:47:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make error message clearer if Node isn't installed (or not found on PATH). Fixes #527

Browse Source
This commit is contained in:
SteveSandersonMS
2017-01-03 10:59:26 +00:00
parent 70f59fc8ec
commit fbb8054c2e
1 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs
View File

@@ -222,7 +222,7 @@ If you haven't yet installed node-inspector, you can do so as follows:
} }
else else
{ {
debuggingArgs = string.Empty; debuggingArgs = string.Empty;
} }
var thisProcessPid = Process.GetCurrentProcess().Id; var thisProcessPid = Process.GetCurrentProcess().Id;
@@ -325,17 +325,26 @@ If you haven't yet installed node-inspector, you can do so as follows:
private static Process LaunchNodeProcess(ProcessStartInfo startInfo) private static Process LaunchNodeProcess(ProcessStartInfo startInfo)
{ {
var process = Process.Start(startInfo); try {
var process = Process.Start(startInfo);
// On Mac at least, a killed child process is left open as a zombie until the parent // On Mac at least, a killed child process is left open as a zombie until the parent
// captures its exit code. We don't need the exit code for this process, and don't want // captures its exit code. We don't need the exit code for this process, and don't want
// to use process.WaitForExit() explicitly (we'd have to block the thread until it really // to use process.WaitForExit() explicitly (we'd have to block the thread until it really
// has exited), but we don't want to leave zombies lying around either. It's sufficient // has exited), but we don't want to leave zombies lying around either. It's sufficient
// to use process.EnableRaisingEvents so that .NET will grab the exit code and let the // to use process.EnableRaisingEvents so that .NET will grab the exit code and let the
// zombie be cleaned away without having to block our thread. // zombie be cleaned away without having to block our thread.
process.EnableRaisingEvents = true; process.EnableRaisingEvents = true;
return process; return process;
} catch (Exception ex) {
var message = "Failed to start Node process. To resolve this:.\n\n"
+ "[1] Ensure that Node.js is installed and can be found in one of the PATH directories.\n"
+ $" Current PATH enviroment variable is: { Environment.GetEnvironmentVariable("PATH") }\n"
+ " Make sure the Node executable is in one of those directories, or update your PATH.\n\n"
+ "[2] See the InnerException for further details of the cause.";
throw new InvalidOperationException(message, ex);
}
} }
private static string UnencodeNewlines(string str) private static string UnencodeNewlines(string str)