Make the Webpack Dependency in the aspnet-webpack NPM Package a Peer Dependency #1412

Closed
opened 2025-08-09 17:20:02 +00:00 by fergalmoran · 0 comments
Owner

Originally created by @thoughtentity on 8/27/2016

Make the Webpack Dependency in the aspnet-webpack NPM Package a Peer Dependency

Proposed Changes

This pull request changes the package.json file in the aspnet-webpack npm package by moving the webpack dependency from devDependencies to peerDependencies. This makes the Webpack dependency soft and allows the webpack-dev-middleware in aspnet-webpack to pickup the Webpack version being used by the user further up the dependency chain. The pull request also adds tsd to devDependencies to allow the aspnet-webpack's npm prepublish script to run without a global tsd install.

[package.json] Add webpack to peerDependencies

{
    "peerDependencies": {
        "webpack": "^1.13.2" 
    }
}

[package.json] Add tsd to devDependencies

{
    "devDependencies": {
        "tsd": "0.6.5"
    }
}

This pull request fixes #283

*Originally created by @thoughtentity on 8/27/2016* ## Make the Webpack Dependency in the aspnet-webpack NPM Package a Peer Dependency ### Proposed Changes This pull request changes the `package.json` file in the `aspnet-webpack` npm package by moving the webpack dependency from `devDependencies` to `peerDependencies`. This makes the Webpack dependency soft and allows the `webpack-dev-middleware` in `aspnet-webpack` to pickup the Webpack version being used by the user further up the dependency chain. The pull request also adds `tsd` to `devDependencies` to allow the `aspnet-webpack`'s npm prepublish script to run without a global tsd install. > [**package.json**] Add `webpack` to `peerDependencies` ``` json { "peerDependencies": { "webpack": "^1.13.2" } } ``` > [**package.json**] Add `tsd` to `devDependencies` ``` json { "devDependencies": { "tsd": "0.6.5" } } ``` ### Related Issues This pull request fixes #283
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/JavaScriptServices#1412
No description provided.