FIxing path separator to address #247 #1448

Closed
opened 2025-08-09 17:20:11 +00:00 by fergalmoran · 0 comments
Owner

Originally created by @aaronpowell on 8/7/2016

When investigating #247 I noticed that the NODE_PATH would look something like:

C:\tmp\.nvm\v6.3.1\node_modules:C:\_code\project\node_modules

The problem is that the path separator is : not ;.

This fix have resolve the issue in my testing.

Testing fix

  1. Create a new project using the yeoman generator
  2. Enable server side rendering
  3. Set NODE_PATH to have a value (eg: C:\tmp)
  4. Run the application and experience the error described in #247
  5. Apply patch
  6. Run the application successfully
*Originally created by @aaronpowell on 8/7/2016* When investigating #247 I noticed that the `NODE_PATH` would look something like: `C:\tmp\.nvm\v6.3.1\node_modules:C:\_code\project\node_modules` The problem is that the path separator is `:` not `;`. This fix have resolve the issue in my testing. ## Testing fix 1. Create a new project using the yeoman generator 2. Enable server side rendering 3. Set `NODE_PATH` to have a value (eg: `C:\tmp`) 4. Run the application and experience the error described in #247 5. Apply patch 6. Run the application successfully
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/JavaScriptServices#1448
No description provided.