Using a custom logger for the node output. #1574

New Issue

fergalmoran · 2025-08-09T17:20:42Z

fergalmoran commented

2025-08-09 17:20:42 +00:00

Originally created by @pauldotknopf on 6/9/2016

https://github.com/aspnet/JavaScriptServices/blob/f2e89fd/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs#L154

Applications don't always run from the command prompt. I realize we probably don't want to reference Microsoft's new logging interfaces, so what about adding support for some ILogger interface that implementations could chose to do what they want with the output.

Or, make the SocketNodeInstance and HttpNodeInstance types public so that we may inherit and override the members.

I am open to creating a pull request if we can agree on an approach.

*Originally created by @pauldotknopf on 6/9/2016* https://github.com/aspnet/JavaScriptServices/blob/f2e89fd/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs#L154 Applications don't always run from the command prompt. I realize we probably don't want to reference Microsoft's new logging interfaces, so what about adding support for some `ILogger` interface that implementations could chose to do what they want with the output. Or, make the `SocketNodeInstance` and `HttpNodeInstance` types public so that we may inherit and override the members. I am open to creating a pull request if we can agree on an approach.

fergalmoran closed this issue

2025-08-09 17:20:42 +00:00

fergalmoran added the enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement labels 2025-08-09 17:20:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/JavaScriptServices#1574