Expose Node.js Options #47

New Issue

fergalmoran · 2025-08-09T17:14:47Z

fergalmoran commented

2025-08-09 17:14:47 +00:00

Originally created by @JeremyTCD on 6/5/2018

@SteveSandersonMS kindly consider.

Goal:
Allow INodeServices consumers to specify Node.js Options such as --inspect-brk. The merits of exposing Node.js options were discussed in these issues:

Summary of changes:
I've made some changes that allow for node options to be specified. Backward compatibility has been preserved.

Added NodeServicesOptions.NodeOptions.
Added nodeOptions parameter to an overload of OutOfProcessNodeInstance's constructor.
Added nodeOptions parameter to an overload of OutOfProcessNodeInstance.PrepareNodeProcessStartInfo.
Updated HttpNodeInstance and SocketNodeInstance (classes that implement OutOfProcessNodeInstance ) to pass NodeServicesOptions.NodeOptions to OutOfProcessNodeInstances's constructor.

If these changes are acceptable, I'll update the ReadMe as well. Thanks for considering.

*Originally created by @JeremyTCD on 6/5/2018* @SteveSandersonMS kindly consider. Goal: Allow `INodeServices` consumers to specify Node.js Options such as `--inspect-brk`. The merits of exposing Node.js options were discussed in these issues: - https://github.com/aspnet/JavaScriptServices/issues/796 - https://github.com/aspnet/JavaScriptServices/pull/804 Summary of changes: I've made some changes that allow for node options to be specified. Backward compatibility has been preserved. - Added `NodeServicesOptions.NodeOptions`. - Added `nodeOptions` parameter to an overload of `OutOfProcessNodeInstance`'s constructor. - Added `nodeOptions` parameter to an overload of `OutOfProcessNodeInstance.PrepareNodeProcessStartInfo`. - Updated HttpNodeInstance and SocketNodeInstance (classes that implement OutOfProcessNodeInstance ) to pass `NodeServicesOptions.NodeOptions` to `OutOfProcessNodeInstances`'s constructor. If these changes are acceptable, I'll update the ReadMe as well. Thanks for considering.

fergalmoran closed this issue

2025-08-09 17:14:47 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/JavaScriptServices#47