github/android-dev-ext
1
1
Fork 0
mirror of https://github.com/adelphes/android-dev-ext.git synced 2025-12-22 09:29:38 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

Ignore DDM chunk commands (#138)

Browse Source 
Honestly, I have no idea why, but ADB occasionally returns DDM chunk
chunk commands for commands for which we previously received a response.
These commands are characterized by the commandset 199 (which is in the
custom vendor range of 128-255) and a command of 1.

Because these responses refer to commands for which we've already
received a response, the code actually blows up entirely with a (hidden)
null reference exception in the error printing code (it attempts to
dereference this.command which is now undefined).

This fix adds special handling for these commands, though nothing
sophisticated: it just ignores them.

In addition, we fix up the error handling code so that if multiple
responses for a command are received in the future, we don't blow up.
This commit is contained in:
Brett Kosinski
2024-01-02 02:35:13 -07:00
committed by GitHub
parent 33dd93da0c
commit 456c4f935f
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/jdwp.js
View File

@@ -99,9 +99,26 @@ class Reply {
return;
}
if (this.errorcode === 50945) {
// errorcode===50945 (0xC701) refers to a DDM chunk (set 199, cmd 1) for a
// previous command. It's unclear why these are being sent but it appears
// they're safe to ignore.
//
// see https://android.googlesource.com/platform/art/+/master/adbconnection/adbconnection.cc
this.decoded = {
empty: true,
errorcode: 0
}
return;
}
if (this.errorcode !== 0) {
// https://docs.oracle.com/javase/7/docs/platform/jpda/jdwp/jdwp-protocol.html#JDWP_Error
E(`JDWP command failed '${this.command.name}'. Error ${this.errorcode}`, this);
if (this.command !== undefined) {
E(`JDWP command failed '${this.command.name}'. Error ${this.errorcode}`, this);
} else {
E(`Unknown JDWP command with id '${this.id}' failed. Error ${this.errorcode}`, this);
}
}
if (!this.errorcode && this.command && this.command.replydecodefn) {