updated validation to use new JavaTypes module instead of MTIs

langserver/java/validation/bad-overrides.js

@@ -0,0 +1,72 @@
+const { ModuleBlock, TextBlock } = require('../parser9');
+const ParseProblem = require('../parsetypes/parse-problem');
+const {SourceType} = require('../source-type');
+const {CEIType, Method} = require('java-mti');
+
+function nonAbstractLabel(label) {
+    return label.replace(/\babstract /g, '');
+}
+
+/**
+ * @param {SourceType} source_type 
+ * @param {*} probs 
+ */
+function checkOverrides(source_type, probs) {
+    if (source_type.extends_types.length === 0) {
+        return;
+    }
+    if (source_type.typeKind !== 'class') {
+        return;
+    }
+
+    /** @type {{ann:TextBlock, method:Method, method_id:string}[]} */
+    const overriden_methods = [];
+    source_type.methods.reduce((arr, method) => {
+        const ann = method._decl.annotations.find(a => /^@\s*Override$/.test(a.source));
+        if (ann) {
+            arr.push({
+                ann,
+                method,
+                method_id: `${method.name}${method.methodSignature}`,
+            })
+        }
+        return arr;
+    }, overriden_methods);
+
+    if (!overriden_methods.length) {
+        return;
+    }
+
+    const methods = new Set(), supers_done = new Set();
+    const supers = source_type.supers.slice();
+    while (supers.length) {
+        const s = supers.shift();
+        supers_done.add(s);
+        s.methods.forEach(m => {
+            methods.add(`${m.name}${m.methodSignature}`);
+        });
+        if (s instanceof CEIType) {
+            s.supers.filter(s => !supers_done.has(s)).forEach(s => supers.push(s));
+        }
+    }
+
+    overriden_methods.forEach(x => {
+        if (!methods.has(x.method_id)) {
+            probs.push(ParseProblem.Error(x.ann, `${x.method.label} does not override a matching method in any inherited type or interface`));
+        }
+    })
+}
+
+/**
+ * @param {ModuleBlock} mod 
+ * @param {*} imports
+ * @param {SourceType[]} source_types
+ */
+module.exports = function(mod, imports, source_types) {
+    /** @type {ParseProblem[]} */
+    const probs = [];
+      
+    source_types.forEach(type => checkOverrides(type, probs));
+      
+    return probs;
+}