Ignore DDM chunk commands #22

New Issue

fergalmoran · 2025-08-09T17:12:59Z

fergalmoran commented

2025-08-09 17:12:59 +00:00

Originally created by @fancypantalons on 11/30/2023

Honestly, I have no idea why, but ADB occasionally returns DDM chunk chunk commands for commands for which we previously received a response. These commands are characterized by the commandset 199 (which is in the custom vendor range of 128-255) and a command of 1.

Because these responses refer to commands for which we've already received a response, the code actually blows up entirely with a (hidden) null reference exception in the error printing code (it attempts to dereference this.command which is now undefined).

This fix adds special handling for these commands, though nothing sophisticated: it just ignores them.

In addition, we fix up the error handling code so that if multiple responses for a command are received in the future, we don't blow up.

*Originally created by @fancypantalons on 11/30/2023* Honestly, I have no idea why, but ADB occasionally returns DDM chunk chunk commands for commands for which we previously received a response. These commands are characterized by the commandset 199 (which is in the custom vendor range of 128-255) and a command of 1. Because these responses refer to commands for which we've already received a response, the code actually blows up entirely with a (hidden) null reference exception in the error printing code (it attempts to dereference this.command which is now undefined). This fix adds special handling for these commands, though nothing sophisticated: it just ignores them. In addition, we fix up the error handling code so that if multiple responses for a command are received in the future, we don't blow up.

fergalmoran closed this issue

2025-08-09 17:12:59 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/android-dev-ext#22