fergalmoran/DnsServer
1
0
Fork 0
mirror of https://github.com/fergalmoran/DnsServer.git synced 2026-01-05 16:24:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

CacheZone: fixed bug in QueryRecords() which returned CNAME with special dns record RDATA. Updated SetRecords to remove old CNAME only when its RDATA is DnsCNAMERecord.

Browse Source
This commit is contained in:
Shreyas Zare
2021-03-06 16:34:17 +05:30
parent 0002a5c850
commit 03a51d3d22
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
DnsServerCore/Dns/Zones/CacheZone.cs
View File

@@ -21,6 +21,7 @@ using System;
using System.Collections.Generic;
using TechnitiumLibrary.IO;
using TechnitiumLibrary.Net.Dns;
using TechnitiumLibrary.Net.Dns.ResourceRecords;
namespace DnsServerCore.Dns.Zones
{
@@ -120,7 +121,15 @@ namespace DnsServerCore.Dns.Zones
default:
//remove old CNAME entry since current new entry type overlaps any existing CNAME entry in cache
//keeping both entries will create issue with serve stale implementation since stale CNAME entry will be always returned
_entries.TryRemove(DnsResourceRecordType.CNAME, out _);
if (_entries.TryGetValue(DnsResourceRecordType.CNAME, out IReadOnlyList<DnsResourceRecord> cnameRecords))
{
if ((cnameRecords.Count > 0) && (cnameRecords[0].RDATA is DnsCNAMERecord))
{
//delete CNAME entry only when it contains DnsCNAMERecord RDATA and not special cache records
_entries.TryRemove(DnsResourceRecordType.CNAME, out _);
}
}
break;
}
}
@@ -170,7 +179,10 @@ namespace DnsServerCore.Dns.Zones
{
IReadOnlyList<DnsResourceRecord> filteredRecords = FilterExpiredRecords(type, existingCNAMERecords, serveStale, filterSpecialCacheRecords);
if (filteredRecords.Count > 0)
return filteredRecords;
{
if ((type == DnsResourceRecordType.CNAME) || (filteredRecords[0].RDATA is DnsCNAMERecord))
return filteredRecords;
}
}
if (_entries.TryGetValue(type, out IReadOnlyList<DnsResourceRecord> existingRecords))