fergalmoran/DnsServer
1
0
Fork 0
mirror of https://github.com/fergalmoran/DnsServer.git synced 2026-02-25 09:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

PrimarySubDomainZone: Fixed issue of duplicate records in zone history.

Browse Source
This commit is contained in:
Shreyas Zare
2023-08-12 13:03:38 +05:30
parent 9150dd5e73
commit 481a92b494
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
DnsServerCore/Dns/Zones/PrimarySubDomainZone.cs
View File

@@ -140,14 +140,17 @@ namespace DnsServerCore.Dns.Zones
if (record.OriginalTtlValue > _primaryZone.GetZoneSoaExpire())
throw new DnsServerException("Failed to add record: TTL cannot be greater than SOA EXPIRE.");
base.AddRecord(record);
AddRecord(record, out IReadOnlyList<DnsResourceRecord> addedRecords, out IReadOnlyList<DnsResourceRecord> deletedRecords);
_primaryZone.CommitAndIncrementSerial(null, new DnsResourceRecord[] { record });
if (addedRecords.Count > 0)
{
_primaryZone.CommitAndIncrementSerial(deletedRecords, addedRecords);
if (_primaryZone.DnssecStatus != AuthZoneDnssecStatus.Unsigned)
_primaryZone.UpdateDnssecRecordsFor(this, record.Type);
if (_primaryZone.DnssecStatus != AuthZoneDnssecStatus.Unsigned)
_primaryZone.UpdateDnssecRecordsFor(this, record.Type);
_primaryZone.TriggerNotify();
_primaryZone.TriggerNotify();
}
break;
}
}
@@ -235,9 +238,13 @@ namespace DnsServerCore.Dns.Zones
if (!TryDeleteRecord(oldRecord.Type, oldRecord.RDATA, out DnsResourceRecord deletedRecord))
throw new InvalidOperationException("Cannot update record: the record does not exists to be updated.");
base.AddRecord(newRecord);
AddRecord(newRecord, out IReadOnlyList<DnsResourceRecord> addedRecords, out IReadOnlyList<DnsResourceRecord> deletedRecords);
_primaryZone.CommitAndIncrementSerial(new DnsResourceRecord[] { deletedRecord }, new DnsResourceRecord[] { newRecord });
List<DnsResourceRecord> allDeletedRecords = new List<DnsResourceRecord>(deletedRecords.Count + 1);
allDeletedRecords.Add(deletedRecord);
allDeletedRecords.AddRange(deletedRecords);
_primaryZone.CommitAndIncrementSerial(allDeletedRecords, addedRecords);
if (_primaryZone.DnssecStatus != AuthZoneDnssecStatus.Unsigned)
_primaryZone.UpdateDnssecRecordsFor(this, oldRecord.Type);