fergalmoran/DnsServer
1
0
Fork 0
mirror of https://github.com/fergalmoran/DnsServer.git synced 2026-01-07 09:14:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Zone: fixed issue in SetRecords() with stale record getting overwritten by failure record in cache.

Browse Source
This commit is contained in:
Shreyas Zare
2019-06-29 12:08:57 +05:30
parent f966693502
commit c8367f191d
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
DnsServerCore/Dns/Zone.cs
View File

@@ -374,7 +374,17 @@ namespace DnsServerCore.Dns
private void SetRecords(DnsResourceRecordType type, DnsResourceRecord[] records)
{
_entries.AddOrUpdate(type, records, delegate (DnsResourceRecordType key, DnsResourceRecord[] existingRecords)
if (!_authoritativeZone && (records.Length > 0) && (records[0].RDATA is DnsCache.DnsFailureRecord))
{
//call trying to cache failure record
if (_entries.TryGetValue(type, out DnsResourceRecord[] existingRecords))
{
if ((existingRecords.Length > 0) && !(existingRecords[0].RDATA is DnsCache.DnsFailureRecord))
return; //skip to avoid overwriting a useful stale record with a failure record to allow serve-stale to work as intended
}
}
_entries.AddOrUpdate(type, records, delegate (DnsResourceRecordType key, DnsResourceRecord[] existingValues)
{
return records;
});
@@ -393,7 +403,7 @@ namespace DnsServerCore.Dns
default:
//remove old CNAME entry since current new entry type overlaps any existing CNAME entry in cache
//keeping both entries will create issue with serve stale implementation since stale CNAME entry will be always returned
_entries.TryRemove(DnsResourceRecordType.CNAME, out DnsResourceRecord[] existingValues);
_entries.TryRemove(DnsResourceRecordType.CNAME, out _);
break;
}
}