fergalmoran/DnsServer
1
0
Fork 0
mirror of https://github.com/fergalmoran/DnsServer.git synced 2026-02-05 15:33:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

AuthManager: code refactoring done.

Browse Source
This commit is contained in:
Shreyas Zare
2024-05-19 14:50:43 +05:30
parent 04de9120b8
commit f8fe1b5bb6
1 changed files with 37 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
DnsServerCore/Auth/AuthManager.cs
View File

@@ -1,6 +1,6 @@
/*
Technitium DNS Server
Copyright (C) 2022 Shreyas Zare (shreyas@technitium.com)
Copyright (C) 2024 Shreyas Zare (shreyas@technitium.com)
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -48,7 +48,7 @@ namespace DnsServerCore.Auth
readonly string _configFolder;
readonly LogManager _log;
readonly object _lockObj = new object();
readonly object _saveLock = new object();
bool _pendingSave;
readonly Timer _saveTimer;
const int SAVE_TIMER_INITIAL_INTERVAL = 10000;
@@ -62,7 +62,24 @@ namespace DnsServerCore.Auth
_configFolder = configFolder;
_log = log;
_saveTimer = new Timer(SaveTimerCallback, null, Timeout.Infinite, Timeout.Infinite);
_saveTimer = new Timer(delegate (object state)
{
lock (_saveLock)
{
try
{
SaveConfigFileInternal();
}
catch (Exception ex)
{
_log.Write(ex);
}
finally
{
_pendingSave = false;
}
}
});
}
#endregion
@@ -76,12 +93,22 @@ namespace DnsServerCore.Auth
if (_disposed)
return;
if (_saveTimer is not null)
_saveTimer.Dispose();
_saveTimer?.Dispose();
lock (_lockObj)
lock (_saveLock)
{
SaveConfigFileInternal();
try
{
SaveConfigFileInternal();
}
catch (Exception ex)
{
_log.Write(ex);
}
finally
{
_pendingSave = false;
}
}
_disposed = true;
@@ -91,22 +118,6 @@ namespace DnsServerCore.Auth
#region private
private void SaveTimerCallback(object state)
{
try
{
lock (_lockObj)
{
_pendingSave = false;
SaveConfigFileInternal();
}
}
catch (Exception ex)
{
_log.Write(ex);
}
}
private void CreateDefaultConfig()
{
Group adminGroup = CreateGroup(Group.ADMINISTRATORS, "Super administrators");
@@ -797,7 +808,7 @@ namespace DnsServerCore.Auth
else
user.ChangePassword(password);
lock (_lockObj)
lock (_saveLock)
{
SaveConfigFileInternal();
}
@@ -805,7 +816,7 @@ namespace DnsServerCore.Auth
public void LoadConfigFile(UserSession implantSession = null)
{
lock (_lockObj)
lock (_saveLock)
{
_groups.Clear();
_users.Clear();
@@ -818,7 +829,7 @@ namespace DnsServerCore.Auth
public void SaveConfigFile()
{
lock (_lockObj)
lock (_saveLock)
{
if (_pendingSave)
return;