fergalmoran/Readarr
1
0
Fork 0
mirror of https://github.com/fergalmoran/Readarr.git synced 2026-01-02 23:04:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed: Calibre authentication with Basic auth

Browse Source
This commit is contained in:
ta264
2021-11-14 21:06:02 +00:00
parent 0bb391235f
commit 5d63ef01b6
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/NzbDrone.Common.Test/Http/HttpClientFixture.cs
View File

@@ -823,7 +823,7 @@ namespace NzbDrone.Common.Test.Http
}
[Test]
public void should_correctly_use_basic_auth()
public void should_correctly_use_basic_auth_with_basic_network_credential()
{
var request = new HttpRequest($"https://{_httpBinHost}/basic-auth/username/password");
request.Credentials = new BasicNetworkCredential("username", "password");
@@ -833,6 +833,17 @@ namespace NzbDrone.Common.Test.Http
response.StatusCode.Should().Be(HttpStatusCode.OK);
}
[Test]
public void should_correctly_use_basic_auth_with_network_credential()
{
var request = new HttpRequest($"https://{_httpBinHost}/basic-auth/username/password");
request.Credentials = new NetworkCredential("username", "password");
var response = Subject.Execute(request);
response.StatusCode.Should().Be(HttpStatusCode.OK);
}
[Test]
public void should_correctly_use_digest_auth()
{

7
src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs
View File

@@ -68,8 +68,11 @@ namespace NzbDrone.Common.Http.Dispatchers
else if (request.Credentials is NetworkCredential nc)
{
var creds = GetCredentialCache();
creds.Remove((Uri)request.Url, "Digest");
creds.Add((Uri)request.Url, "Digest", nc);
foreach (var authtype in new[] { "Basic", "Digest" })
{
creds.Remove((Uri)request.Url, authtype);
creds.Add((Uri)request.Url, authtype, nc);
}
}
}