fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Improve error message for IDL generation with missing interface

Browse Source 
Instead of a cryptic error that occurs due to an interface with no name,
fail early on by explicitly checking that an interface was parsed with a
name.
This commit is contained in:
Shannon Booth
2024-04-21 12:34:56 +12:00
committed by Andreas Kling
parent 91efa1d568
commit 10add8aa8a
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp
View File

@@ -434,8 +434,15 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
// TODO: service_worker_exposed
for (size_t i = 0; i < paths.size(); ++i) {
IDL::Parser parser(paths[i], file_contents[i], lexical_base.string());
TRY(add_to_interface_sets(parser.parse(), intrinsics, window_exposed, dedicated_worker_exposed, shared_worker_exposed));
auto const& path = paths[i];
IDL::Parser parser(path, file_contents[i], lexical_base.string());
auto& interface = parser.parse();
if (interface.name.is_empty()) {
s_error_string = ByteString::formatted("Interface for file {} missing", path);
return Error::from_string_view(s_error_string.view());
}
TRY(add_to_interface_sets(interface, intrinsics, window_exposed, dedicated_worker_exposed, shared_worker_exposed));
parsers.append(move(parser));
}