mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-04-05 12:16:36 +00:00
LibC: Fix off-by-one in snprintf()
snprintf is supposed to *always* NUL-terminate its output, so it has to write one output byte fewer. And yes, I *did* check all existing usages; this shouldn't break anything.
This commit is contained in:
committed by
Andreas Kling
parent
499e953380
commit
2d34f0f93a
@@ -889,10 +889,16 @@ ALWAYS_INLINE void sized_buffer_putch(char*& bufptr, char ch)
|
||||
|
||||
int vsnprintf(char* buffer, size_t size, const char* fmt, va_list ap)
|
||||
{
|
||||
__vsnprintf_space_remaining = size;
|
||||
if (size) {
|
||||
__vsnprintf_space_remaining = size - 1;
|
||||
} else {
|
||||
__vsnprintf_space_remaining = 0;
|
||||
}
|
||||
int ret = printf_internal(sized_buffer_putch, buffer, fmt, ap);
|
||||
if (__vsnprintf_space_remaining) {
|
||||
buffer[ret] = '\0';
|
||||
} else if (size > 0) {
|
||||
buffer[size - 1] = '\0';
|
||||
}
|
||||
return ret;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user