fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-04-05 04:06:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWasm: Properly read blocktypes

Browse Source 
This works for now, but is technically still not spec compliant. Right
now, we're (potentially) missing one bit when reading function indices.
See the relevant issue: #24462.
This commit is contained in:
Diego
2024-05-29 10:31:30 -07:00
committed by Ali Mohammad Pur
parent 637ccacce5
commit 4eaabdad34
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWasm/Parser/Parser.cpp
View File

@@ -254,10 +254,12 @@ ParseResult<BlockType> BlockType::parse(Stream& stream)
ReconsumableStream new_stream { stream };
new_stream.unread({ &kind, 1 });
auto index_value_or_error = stream.read_value<LEB128<ssize_t>>();
// FIXME: should be an i33. Right now, we're missing a potential last bit at
// the end. See https://webassembly.github.io/spec/core/binary/instructions.html#binary-blocktype
auto index_value_or_error = new_stream.read_value<LEB128<i32>>();
if (index_value_or_error.is_error())
return with_eof_check(stream, ParseError::ExpectedIndex);
ssize_t index_value = index_value_or_error.release_value();
i32 index_value = index_value_or_error.release_value();
if (index_value < 0) {
dbgln("Invalid type index {}", index_value);