fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-04-05 04:06:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK: Remove a redundant double find-call in HashMap::ensure

Browse Source 
If the value was found there's no reason to search for it again.
This commit is contained in:
Idan Horowitz
2021-09-10 01:41:40 +03:00
parent 706323beb1
commit 679bde06ed
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
AK/HashMap.h
View File

@@ -134,8 +134,10 @@ public:
V& ensure(const K& key)
{
auto it = find(key);
if (it == end())
set(key, V());
if (it != end())
return it->value;
auto result = set(key, V());
VERIFY(result == HashSetResult::InsertedNewEntry);
return find(key)->value;
}
@@ -143,9 +145,10 @@ public:
V& ensure(K const& key, Callback initialization_callback)
{
auto it = find(key);
if (it == end()) {
set(key, initialization_callback());
}
if (it != end())
return it->value;
auto result = set(key, initialization_callback());
VERIFY(result == HashSetResult::InsertedNewEntry);
return find(key)->value;
}