Enable -Wimplicit-fallthrough.

2026-02-05 15:27:04 +00:00 · 2019-02-15 12:39:16 +01:00
parent 56f0a30f9b
commit df6aaaeeef
11 changed files with 12 additions and 12 deletions
--- a/Applications/About/Makefile
+++ b/Applications/About/Makefile
@@ -6,7 +6,7 @@ APP = About
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../.. -I. -I../../LibC
--- a/Applications/Clock/Makefile
+++ b/Applications/Clock/Makefile
@@ -7,7 +7,7 @@ APP = Clock
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../.. -I. -I../../LibC
--- a/Applications/FileManager/Makefile
+++ b/Applications/FileManager/Makefile
@@ -7,7 +7,7 @@ APP = FileManager
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../.. -I. -I../../LibC
--- a/Applications/FontEditor/Makefile
+++ b/Applications/FontEditor/Makefile
@@ -7,7 +7,7 @@ APP = FontEditor
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../.. -I. -I../../LibC
--- a/Applications/Launcher/Makefile
+++ b/Applications/Launcher/Makefile
@@ -6,7 +6,7 @@ APP = Launcher
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../.. -I. -I../../LibC
--- a/Applications/Terminal/Makefile
+++ b/Applications/Terminal/Makefile
@@ -7,7 +7,7 @@ APP = Terminal
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../.. -I. -I../../LibC
--- a/Kernel/Makefile
+++ b/Kernel/Makefile
@@ -85,7 +85,7 @@ IMAGE = .floppy-image
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 KERNEL_FLAGS = -ffreestanding -fno-stack-protector -fno-ident -fno-builtin
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -mregparm=3 -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables -fno-omit-frame-pointer
 INCLUDE_FLAGS = -I.. -I.
--- a/Kernel/VirtualConsole.cpp
+++ b/Kernel/VirtualConsole.cpp
@@ -417,14 +417,14 @@ void VirtualConsole::on_char(byte ch)
            return;
        }
        m_escape_state = ExpectIntermediate;
-        // fall through
+        [[fallthrough]];
    case ExpectIntermediate:
        if (is_valid_intermediate_character(ch)) {
            m_intermediates.append(ch);
            return;
        }
        m_escape_state = ExpectFinal;
-        // fall through
+        [[fallthrough]];
    case ExpectFinal:
        if (is_valid_final_character(ch)) {
            m_escape_state = Normal;
--- a/LibC/Makefile
+++ b/LibC/Makefile
@@ -55,7 +55,7 @@ LIBRARY = LibC.a
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 LIBC_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -fomit-frame-pointer -march=i386 -m32 -fno-exceptions -fno-rtti -ffunction-sections -fdata-sections -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -O2 -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I.. -I.
--- a/LibGUI/Makefile
+++ b/LibGUI/Makefile
@@ -37,7 +37,7 @@ LIBRARY = LibGUI.a
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 LIBC_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -fomit-frame-pointer -march=i386 -m32 -fno-exceptions -fno-rtti -ffunction-sections -fdata-sections -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I../LibC -I.. -I.
--- a/Userland/Makefile
+++ b/Userland/Makefile
@@ -64,7 +64,7 @@ APPS = \
 ARCH_FLAGS =
 STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
 USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
 FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
 OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
 INCLUDE_FLAGS = -I.. -I. -I../LibC