fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-02 22:55:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Avoid some redundant calls to Layout::Box::absolute_rect()

Browse Source 
Computing the absolute rect of a box requires walking the chain of
containing blocks and apply any offsets encountered. This can be slow in
deeply nested box trees, so let's at least avoid doing it multiple times
when once is enough.
This commit is contained in:
Andreas Kling
2021-09-15 14:18:17 +02:00
parent 1103eb8d44
commit eac31e21f2
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibWeb/Layout/Box.cpp
View File

@@ -305,11 +305,12 @@ Box::BorderRadiusData Box::normalized_border_radius_data()
auto top_right_radius = computed_values().border_top_right_radius().resolved_or_zero(*this, width()).to_px(*this);
// Scale overlapping curves according to https://www.w3.org/TR/css-backgrounds-3/#corner-overlap
auto bordered_rect = this->bordered_rect();
auto f = 1.0f;
f = min(f, bordered_rect().width() / (float)(top_left_radius + top_right_radius));
f = min(f, bordered_rect().height() / (float)(top_right_radius + bottom_right_radius));
f = min(f, bordered_rect().width() / (float)(bottom_left_radius + bottom_right_radius));
f = min(f, bordered_rect().height() / (float)(top_left_radius + bottom_left_radius));
f = min(f, bordered_rect.width() / (float)(top_left_radius + top_right_radius));
f = min(f, bordered_rect.height() / (float)(top_right_radius + bottom_right_radius));
f = min(f, bordered_rect.width() / (float)(bottom_left_radius + bottom_right_radius));
f = min(f, bordered_rect.height() / (float)(top_left_radius + bottom_left_radius));
top_left_radius = (int)(top_left_radius * f);
top_right_radius = (int)(top_right_radius * f);

5
Userland/Libraries/LibWeb/Layout/Box.h
View File

@@ -34,10 +34,11 @@ public:
Gfx::FloatRect padded_rect() const
{
auto absolute_rect = this->absolute_rect();
Gfx::FloatRect rect;
rect.set_x(absolute_x() - box_model().padding.left);
rect.set_x(absolute_rect.x() - box_model().padding.left);
rect.set_width(width() + box_model().padding.left + box_model().padding.right);
rect.set_y(absolute_y() - box_model().padding.top);
rect.set_y(absolute_rect.y() - box_model().padding.top);
rect.set_height(height() + box_model().padding.top + box_model().padding.bottom);
return rect;
}