Linus Groh a92dc4e30d LibJS: Ensure function declarations don't leak outside function scopes ...

When using VM::set_variable() to put the created ScriptFunction onto a
ScopeObject, we would previously unexpectedly reach the global object as
set_variable() checks each traversed scope for an existing Variable with
the given name - which would cause a leak of the inner function past the
outer function (we even had a test expecting that behaviour!). Now we
first declare functions (as DeclarationKind::Var) before setting them.
This will need some more work to make hoisting across non-lexical scopes
work, but it fixes this specific issue for now.

Fixes #6766.

2021-05-13 23:59:00 +01:00

6.0 KiB

Raw Blame History

View Raw