Brian Gianforcaro afa0fb55b0 Kernel: Don't cast to NetworkOrdered<u16>* from random data ...

NetworkOrdered is a non trivial type, and it's undefined behavior to
cast a random pointer to it and then pretend it's that type.

Instead just call AK::convert_between_host_and_network_endian on the
individual u16*. This suppresses static analysis warnings.

I don't think there was a "bug" in the previous code, it worked, but
it was very brittle.

2021-09-01 18:06:14 +02:00

22 KiB

Raw Blame History

View Raw