Andrew Kaster 6047f1adcb LibJS: Ensure JS::Date has a key function and its vtable is in LibJS ...

Without a key function, the vtable for this class can be emitted into
every shared object or executable that needs it. This can cause bugs and
bad behavior when trying to access the vtable or RTTI for the class.

This is most easily seen when trying to call ``is<JS::Date>``, which
currently will do a dynamic_cast. Based on compiler, linker and loader
choices about ordering, it's possible that the code checking the RTTI
and the code that created the object could have a different vtable and
type_info in mind, causing false negatives for the ``is`` check.

2024-01-12 09:11:18 +01:00

29 KiB

Raw Blame History

View Raw