mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-01-01 14:18:15 +00:00
7ea264a660
Given the following situation:
struct Object : public RefCounted<Object> {
RefPtr<Object> parent;
}
NonnullRefPtr<Object> object = get_some_object();
object = *object->parent;
We would previously crash if 'object' was the only strongly referencing
pointer to 'parent'. This happened because NonnullRefPtr would unref
the outgoing pointee before reffing the incoming pointee.
This patch fixes that by implementing NonnullRefPtr assignments using
pointer swaps, just like RefPtr already did.
77 lines
2.4 KiB
C++
77 lines
2.4 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <AK/TestSuite.h>
|
|
|
|
#include <AK/NonnullRefPtr.h>
|
|
#include <AK/String.h>
|
|
|
|
struct Object : public RefCounted<Object> {
|
|
int x;
|
|
};
|
|
|
|
TEST_CASE(basics)
|
|
{
|
|
auto object = adopt(*new Object);
|
|
EXPECT(object.ptr() != nullptr);
|
|
EXPECT_EQ(object->ref_count(), 1);
|
|
object->ref();
|
|
EXPECT_EQ(object->ref_count(), 2);
|
|
object->deref();
|
|
EXPECT_EQ(object->ref_count(), 1);
|
|
|
|
{
|
|
NonnullRefPtr another = object;
|
|
EXPECT_EQ(object->ref_count(), 2);
|
|
}
|
|
|
|
EXPECT_EQ(object->ref_count(), 1);
|
|
}
|
|
|
|
TEST_CASE(assign_reference)
|
|
{
|
|
auto object = adopt(*new Object);
|
|
EXPECT_EQ(object->ref_count(), 1);
|
|
object = *object;
|
|
EXPECT_EQ(object->ref_count(), 1);
|
|
}
|
|
|
|
TEST_CASE(assign_owner_of_self)
|
|
{
|
|
struct Object : public RefCounted<Object> {
|
|
RefPtr<Object> parent;
|
|
};
|
|
|
|
auto parent = adopt(*new Object);
|
|
auto child = adopt(*new Object);
|
|
child->parent = move(parent);
|
|
|
|
child = *child->parent;
|
|
EXPECT_EQ(child->ref_count(), 1);
|
|
}
|
|
|
|
TEST_MAIN(String)
|