Andreas Kling 7ea264a660 AK: NonnullRefPtr should allow assigning owner to ownee ...

Given the following situation:

    struct Object : public RefCounted<Object> {
        RefPtr<Object> parent;
    }

    NonnullRefPtr<Object> object = get_some_object();
    object = *object->parent;

We would previously crash if 'object' was the only strongly referencing
pointer to 'parent'. This happened because NonnullRefPtr would unref
the outgoing pointee before reffing the incoming pointee.

This patch fixes that by implementing NonnullRefPtr assignments using
pointer swaps, just like RefPtr already did.

2020-01-18 14:40:04 +01:00

2.4 KiB

Raw Blame History

View Raw