devgianlu 0fc02d4d00 LibCrypto: Make PKSystem methods return a ByteBuffer directly ...

It used to be that the caller would supply a buffer to write the output
to. This created an anti-pattern in multiple places where the caller
would allocate a `ByteBuffer` and then use `.bytes()` to provide it to
the `PKSystem` method. Then the callee would resize the output buffer
and reassign it, but because the resize was on `Bytes` and not on
`ByteBuffer`, the caller using the latter would cause a bug.

Additionally, in pretty much all cases the buffer was pre-allocated
shortly before.

2025-01-13 17:00:18 +01:00

14 KiB

Raw Blame History

View Raw