fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-25 17:13:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #947 from phw/PICARD-1329-fix-saving-itunnorm

Browse Source 
PICARD-1329: Fix saving iTunNORM tags to ID3
This commit is contained in:
Laurent Monin
2018-09-04 09:40:16 +02:00
committed by GitHub
parent 4d8a5621e4 4c20e811cf
commit 2ca680926d
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
picard/formats/id3.py
View File

@@ -358,9 +358,9 @@ class ID3File(File):
tmcl.people.append([role, value])
elif name.startswith('comment:'):
desc = name.split(':', 1)[1]
if desc.lower()[:4] == "itun":
if desc.lower()[:4] == 'itun':
tags.delall('COMM:' + desc)
tags.add(id3.COMM(encoding=0, desc=desc, lang='eng', text=[v + b'\x00' for v in values]))
tags.add(id3.COMM(encoding=0, desc=desc, lang='eng', text=[v + '\x00' for v in values]))
else:
tags.add(id3.COMM(encoding=encoding, desc=desc, lang='eng', text=values))
elif name.startswith('lyrics:') or name == 'lyrics':

9
test/test_formats.py
View File

@@ -436,6 +436,15 @@ class CommonTests:
self.assertIn(metadata['work'], loaded_metadata['work'])
self.assertEqual(loaded_metadata['grouping'], '')
@skipUnlessTestfile
def test_save_itunnorm_tag(self):
config.setting['clear_existing_tags'] = True
iTunNORM = '00001E86 00001E86 0000A2A3 0000A2A3 000006A6 000006A6 000078FA 000078FA 00000211 00000211'
metadata = Metadata()
metadata['comment:iTunNORM'] = iTunNORM
new_metadata = save_and_load_metadata(self.filename, metadata)
self.assertEqual(new_metadata['comment:iTunNORM'], iTunNORM)
class FLACTest(CommonTests.FormatsTest):
testfile = 'test.flac'