fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-01-06 08:34:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass command as list to subprocess.call()

Browse Source
This commit is contained in:
Laurent Monin
2014-01-13 13:44:27 +01:00
parent 24528a025e
commit 4096988398
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
setup.py
View File

@@ -14,7 +14,6 @@ from picard import __version__
if sys.version_info < (2, 6):
print "*** You need Python 2.6 or higher to use Picard."
TXPULL_CMD = 'tx pull'
args = {}
@@ -326,14 +325,15 @@ class picard_get_po_files(Command):
self.minimum_perc = int(self.minimum_perc)
def run(self):
txpull_cmd = " ".join([
TXPULL_CMD,
txpull_cmd = [
'tx',
'pull',
'--force',
'--all',
'--minimum-perc=%d' % self.minimum_perc
])
log.info("Running %s" % txpull_cmd)
retcode = subprocess.call(txpull_cmd, shell=True)
]
log.info("Running %s" % " ".join(txpull_cmd))
retcode = subprocess.call(txpull_cmd)
if retcode:
_exit_with_error("Failed to update po files", retcode)
@@ -384,15 +384,16 @@ class picard_update_countries(Command):
country_list = []
if not self.skip_pull:
txpull_cmd = " ".join([
TXPULL_CMD,
txpull_cmd = [
'tx',
'pull',
'--force',
'--resource=musicbrainz.countries',
'--source',
'--language=none',
])
log.info("Running %s" % txpull_cmd)
retcode = subprocess.call(txpull_cmd, shell=True)
]
log.info("Running %s" % " ".join(txpull_cmd))
retcode = subprocess.call(txpull_cmd)
if retcode:
log.error("Failed to update countries (retcode=%d)" % (retcode))