fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-16 04:33:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify images/existing_images/artworktable_class related code

Browse Source
This commit is contained in:
Laurent Monin
2024-05-19 19:18:24 +02:00
parent 3887c8655a
commit 54d2d60dd9
1 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
picard/ui/infodialog.py
View File

@@ -152,34 +152,28 @@ class InfoDialog(PicardDialog):
def __init__(self, obj, parent=None):
super().__init__(parent)
self.obj = obj
self.images = []
self.existing_images = []
self.ui = Ui_InfoDialog()
self._pixmaps = {
'missing': QtGui.QPixmap(":/images/image-missing.png"),
'arrow': QtGui.QPixmap(":/images/arrow.png"),
}
self.images = obj.metadata.images or []
self.existing_images = []
artworktable_class = ArtworkTableSimple
if (isinstance(obj, File)
and isinstance(obj.parent, Track)
or isinstance(obj, Track)
or (isinstance(obj, Album) and obj.get_num_total_files() > 0)):
# Display existing artwork only if selected object is track object
# or linked to a track object or it's an album with files
if (getattr(obj, 'orig_metadata', None) is not None
and obj.orig_metadata.images
and obj.orig_metadata.images != obj.metadata.images):
artworktable_class = ArtworkTableExisting
self.existing_images = obj.orig_metadata.images
has_orig_images = getattr(obj, 'orig_metadata', None) is not None and obj.orig_metadata.images
if has_orig_images and obj.orig_metadata.images != obj.metadata.images:
is_track = isinstance(obj, Track)
is_linked_file = isinstance(obj, File) and isinstance(obj.parent, Track)
is_album_with_files = isinstance(obj, Album) and obj.get_num_total_files() > 0
if is_track or is_linked_file or is_album_with_files:
if self.images:
self.existing_images = obj.orig_metadata.images
artworktable_class = ArtworkTableExisting
else:
self.images = obj.orig_metadata.images
if obj.metadata.images:
self.images = obj.metadata.images
if not self.images and self.existing_images:
self.images = self.existing_images
self.existing_images = []
artworktable_class = ArtworkTableSimple
self.ui.setupUi(self)
self.ui.buttonBox.addButton(
StandardButton(StandardButton.CLOSE), QtWidgets.QDialogButtonBox.ButtonRole.AcceptRole)