fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-01 05:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

coverart: clean up the try_list before checking its length

Browse Source
This commit is contained in:
Wieland Hoffmann
2012-09-01 13:43:51 +02:00
parent 00139fdbad
commit 6fb96c7ec5
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
picard/coverart.py
View File

@@ -106,18 +106,17 @@ def _coverart_downloaded(album, metadata, release, try_list, imagetype, data, ht
for track in album._new_tracks:
track.metadata.add_image(mime, data, filename)
# If the image already was a front image, there might still be some
# other front images in the try_list - remove them.
for item in try_list[:]:
if item['type'] == 'front' and 'archive.org' not in item['host']:
# Hosts other than archive.org only provide front images
# For still remaining front images from archive.org, refer to
# the comment in _caa_json_downloaded (~line 156).
try_list.remove(item)
if len(try_list) == 0:
album._finalize_loading(None)
else:
# If the image already was a front image, there might still be some
# other front images in the try_list - remove them.
for item in try_list[:]:
if item['type'] == 'front' and 'archive.org' not in item['host']:
# Hosts other than archive.org only provide front images
# For still remaining front images from archive.org, refer to
# the comment in _caa_json_downloaded (~line 156).
try_list.remove(item)
coverart(album, metadata, release, try_list)
coverart(album, metadata, release, try_list)
def _caa_json_downloaded(album, metadata, release, try_list, data, http, error):
album._requests -= 1