Remove last bits of deprecated Metadata.delete()

- a note was added to it
- not removed, some plugins might rely on it

picard/album.py

@@ -391,7 +391,7 @@ class Album(DataObject, Item):
         if va:
             tm["compilation"] = "1"
         else:
-            tm.delete("compilation")
+            del tm["compilation"]
         if discpregap:
             tm["~discpregap"] = "1"
 

picard/file.py

@@ -190,7 +190,7 @@ class File(QtCore.QObject, Item):
         self.metadata.copy(metadata)
         if preserve_deleted:
             for tag in deleted_tags:
-                self.metadata.delete(tag)
+                del self.metadata[tag]
         for tag, values in saved_metadata.items():
             self.metadata.set(tag, values)
 

picard/metadata.py

@@ -348,6 +348,7 @@ class Metadata(MutableMapping):
             self.add(name, value)
 
     def delete(self, name):
+        """Deprecated: use del directly"""
         del self[name]
 
     def __iter__(self):

picard/ui/metadatabox.py

@@ -385,7 +385,7 @@ class MetadataBox(QtWidgets.QTableWidget):
             values = []
         if not values and self.tag_is_removable(tag):
             for obj in objects:
-                obj.metadata.delete(tag)
+                del obj.metadata[tag]
         elif values:
             for obj in objects:
                 obj.metadata[tag] = values