fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-03-02 19:43:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move code to generate error message into methods

Browse Source 
* This makes the code structure a bit cleaner
* Also these methods are likely to be reused in other dialog classes
This commit is contained in:
Rahul Raturi
2016-07-25 23:33:46 +05:30
parent e9b0eacafb
commit 7b4e213a30
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
picard/ui/searchdialog.py
View File

@@ -210,6 +210,20 @@ class SearchDialog(PicardDialog):
self.load_selection(row)
self.accept()
def network_error(self, reply, error):
error_msg = _("<strong>Following error occurred while fetching results:<br></strong>"
"Network request error for %s: %s (QT code %d, HTTP code %s)<br>" % (
reply.request().url().toString(QtCore.QUrl.RemoveUserInfo),
reply.errorString(),
error,
repr(reply.attribute(QtNetwork.QNetworkRequest.HttpStatusCodeAttribute)))
)
self.show_error(error_msg, show_retry_button=True)
def no_results_found(self):
error_msg = _("<strong>No results found. Please try a different search query.</strong>")
self.show_error(error_msg)
def accept(self):
if getattr(self, "table", None):
sel_rows = self.table.selectionModel().selectedRows()
@@ -309,21 +323,13 @@ class TrackSearchDialog(SearchDialog):
def handle_reply(self, document, http, error):
if error:
error_msg = _("<strong>Following network request error occurred while fetching results:<br></strong>"
"Network request error for %s: %s (QT code %d, HTTP code %s)<br>" % (
http.request().url().toString(QtCore.QUrl.RemoveUserInfo),
http.errorString(),
error,
repr(http.attribute(QtNetwork.QNetworkRequest.HttpStatusCodeAttribute)))
)
self.show_error(error_msg, show_retry_button=True)
self.network_error(http, error)
return
try:
tracks = document.metadata[0].recording_list[0].recording
except (AttributeError, IndexError):
error_msg = _("<strong>No results found. Please try a different search query.</strong>")
self.show_error(error_msg)
self.no_results_found()
return
if self.file_: