fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-24 00:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #852 from zas/PICARD-1202

Browse Source 
PICARD-1202: only use current item if there's actually one
This commit is contained in:
Laurent Monin
2018-02-28 11:58:45 +01:00
committed by GitHub
parent e29ec9712c af8af574c6
commit 8236dedbbd
1 changed files with 33 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
picard/ui/metadatabox.py
View File

@@ -290,38 +290,39 @@ class MetadataBox(QtWidgets.QTableWidget):
removals = []
useorigs = []
item = self.currentItem()
column = item.column()
for tag in tags:
if tag in self.lookup_tags().keys():
if (column == 1 or column == 2) and len(tags) == 1 and item.text():
if column == 1:
values = self.tag_diff.orig[tag]
else:
values = self.tag_diff.new[tag]
lookup_action = QtWidgets.QAction(_("Lookup in &Browser"), self.parent)
lookup_action.triggered.connect(partial(self.open_link, values, tag))
menu.addAction(lookup_action)
if self.tag_is_removable(tag):
removals.append(partial(self.remove_tag, tag))
status = self.tag_diff.status[tag] & TagStatus.Changed
if status == TagStatus.Changed or status == TagStatus.Removed:
for file in self.files:
objects = [file]
if file.parent in self.tracks and len(self.files & set(file.parent.linked_files)) == 1:
objects.append(file.parent)
orig_values = list(file.orig_metadata.getall(tag)) or [""]
useorigs.append(partial(self.set_tag_values, tag, orig_values, objects))
if removals:
remove_tag_action = QtWidgets.QAction(_("Remove"), self.parent)
remove_tag_action.triggered.connect(lambda: [f() for f in removals])
remove_tag_action.setShortcut(self.remove_tag_shortcut.key())
menu.addAction(remove_tag_action)
if useorigs:
name = ngettext("Use Original Value", "Use Original Values", len(useorigs))
use_orig_value_action = QtWidgets.QAction(name, self.parent)
use_orig_value_action.triggered.connect(lambda: [f() for f in useorigs])
menu.addAction(use_orig_value_action)
menu.addSeparator()
if item:
column = item.column()
for tag in tags:
if tag in self.lookup_tags().keys():
if (column == 1 or column == 2) and len(tags) == 1 and item.text():
if column == 1:
values = self.tag_diff.orig[tag]
else:
values = self.tag_diff.new[tag]
lookup_action = QtWidgets.QAction(_("Lookup in &Browser"), self.parent)
lookup_action.triggered.connect(partial(self.open_link, values, tag))
menu.addAction(lookup_action)
if self.tag_is_removable(tag):
removals.append(partial(self.remove_tag, tag))
status = self.tag_diff.status[tag] & TagStatus.Changed
if status == TagStatus.Changed or status == TagStatus.Removed:
for file in self.files:
objects = [file]
if file.parent in self.tracks and len(self.files & set(file.parent.linked_files)) == 1:
objects.append(file.parent)
orig_values = list(file.orig_metadata.getall(tag)) or [""]
useorigs.append(partial(self.set_tag_values, tag, orig_values, objects))
if removals:
remove_tag_action = QtWidgets.QAction(_("Remove"), self.parent)
remove_tag_action.triggered.connect(lambda: [f() for f in removals])
remove_tag_action.setShortcut(self.remove_tag_shortcut.key())
menu.addAction(remove_tag_action)
if useorigs:
name = ngettext("Use Original Value", "Use Original Values", len(useorigs))
use_orig_value_action = QtWidgets.QAction(name, self.parent)
use_orig_value_action.triggered.connect(lambda: [f() for f in useorigs])
menu.addAction(use_orig_value_action)
menu.addSeparator()
if len(tags) == 1 or removals or useorigs:
menu.addSeparator()
menu.addAction(self.add_tag_action)