fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-01-07 00:54:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-1828: Avoid selection changes when cover art gets updated

Browse Source
This commit is contained in:
Philipp Wolfer
2020-10-29 14:14:58 +01:00
parent a1c09fc1b6
commit 87b94d5829
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
picard/file.py
View File

@@ -262,7 +262,7 @@ class File(QtCore.QObject, Item):
def keep_original_images(self):
self.metadata.images = self.orig_metadata.images.copy()
self.update()
self.update(signal=False)
self.metadata_images_changed.emit()
def has_error(self):

1
picard/track.py
View File

@@ -360,7 +360,6 @@ class Track(DataObject, Item):
self.metadata.images = self.orig_metadata.images.copy()
else:
self.metadata.images = ImageList()
self.update()
class NonAlbumTrack(Track):

14
picard/ui/coverartbox.py
View File

@@ -472,7 +472,7 @@ class CoverArtBox(QtWidgets.QGroupBox):
for file in album.iterfiles():
set_image(file, coverartimage)
file.metadata_images_changed.emit()
file.update()
file.update(signal=False)
album.enable_update_metadata_images(True)
album.update_metadata_images()
album.update(False)
@@ -483,7 +483,7 @@ class CoverArtBox(QtWidgets.QGroupBox):
for file in cluster.iterfiles():
set_image(file, coverartimage)
file.metadata_images_changed.emit()
file.update()
file.update(signal=False)
cluster.enable_update_metadata_images(True)
cluster.update_metadata_images()
cluster.update()
@@ -495,10 +495,11 @@ class CoverArtBox(QtWidgets.QGroupBox):
for file in track.iterfiles():
set_image(file, coverartimage)
file.metadata_images_changed.emit()
file.update()
file.update(signal=False)
track.album.enable_update_metadata_images(True)
track.album.update_metadata_images()
track.album.update(False)
track.update()
elif isinstance(self.item, File):
file = self.item
set_image(file, coverartimage)
@@ -528,6 +529,11 @@ class CoverArtBox(QtWidgets.QGroupBox):
def set_load_image_behavior(self, behavior):
config.setting["load_image_behavior"] = behavior
def keep_original_images(self):
self.item.keep_original_images()
self.cover_art.set_metadata(self.item.metadata)
self.show()
def contextMenuEvent(self, event):
menu = QtWidgets.QMenu(self)
if self.show_details_button.isVisible():
@@ -539,7 +545,7 @@ class CoverArtBox(QtWidgets.QGroupBox):
if self.orig_cover_art.isVisible():
name = _('Keep original cover art')
use_orig_value_action = QtWidgets.QAction(name, self.parent)
use_orig_value_action.triggered.connect(self.item.keep_original_images)
use_orig_value_action.triggered.connect(self.keep_original_images)
menu.addAction(use_orig_value_action)
if self.item and self.item.can_show_coverart: