fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-03-01 11:03:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-855: Adds errorhandler for missing meta-data

Browse Source 
When a track with a non valid total-tracks has multiple release matches
on Picard, picard tries to apply a linear combination  of weights to
detect the best match. In the process it tried to typecast totaltracks
into and int.

This causes a ValueError when totaltracks is not castable into an int.
This commit is contained in:
Sambhav Kothari
2016-12-13 05:39:05 +05:30
parent dcc91099a2
commit 97c83c5777
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
picard/metadata.py
View File

@@ -71,7 +71,7 @@ class Metadata(dict):
if img.is_front_image():
return [img]
return []
def remove_image(self, index):
self.images.pop(index)
@@ -121,13 +121,16 @@ class Metadata(dict):
parts.append((similarity2(a, b), weights["albumartist"]))
if "totaltracks" in self:
a = int(self["totaltracks"])
if "title" in weights:
b = int(release.medium_list[0].medium[0].track_list[0].count)
else:
b = int(release.medium_list[0].track_count[0].text)
score = 0.0 if a > b else 0.3 if a < b else 1.0
parts.append((score, weights["totaltracks"]))
try:
a = int(self["totaltracks"])
if "title" in weights:
b = int(release.medium_list[0].medium[0].track_list[0].count)
else:
b = int(release.medium_list[0].track_count[0].text)
score = 0.0 if a > b else 0.3 if a < b else 1.0
parts.append((score, weights["totaltracks"]))
except ValueError:
pass
preferred_countries = config.setting["preferred_release_countries"]
preferred_formats = config.setting["preferred_release_formats"]