fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-19 06:03:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use memoization for config variables

Browse Source
This commit is contained in:
Gabriel Ferreira
2021-04-08 07:49:20 +02:00
committed by Philipp Wolfer
parent f032b68470
commit 9f005b54e4
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
picard/config.py
View File

@@ -59,6 +59,7 @@ class ConfigSection(QtCore.QObject):
self.__name = name
self.__prefix = self.__name + '/'
self.__prefix_len = len(self.__prefix)
self._memoization = {}
def key(self, name):
return self.__prefix + name
@@ -77,6 +78,8 @@ class ConfigSection(QtCore.QObject):
def __setitem__(self, name, value):
key = self.key(name)
self.__qt_config.setValue(key, value)
if key in self._memoization:
self._memoization[key][0] = False
def __contains__(self, name):
return self.__qt_config.contains(self.key(name))
@@ -86,6 +89,8 @@ class ConfigSection(QtCore.QObject):
config = self.__qt_config
if config.contains(key):
config.remove(key)
if key in self._memoization:
del self._memoization[key]
def raw_value(self, name, qtype=None):
"""Return an option value without any type conversion."""
@@ -99,12 +104,20 @@ class ConfigSection(QtCore.QObject):
def value(self, name, option_type, default=None):
"""Return an option value converted to the given Option type."""
if name in self:
key = self.key(name)
try:
value = self.raw_value(name, qtype=option_type.qtype)
value = option_type.convert(value)
except Exception as why:
log.error('Cannot read %s value: %s', self.key(name), why, exc_info=True)
value = default
valid, value = self._memoization[key]
except KeyError:
valid = False
if not valid:
try:
value = self.raw_value(name, qtype=option_type.qtype)
value = option_type.convert(value)
self._memoization[key] = [True, value]
except Exception as why:
log.error('Cannot read %s value: %s', self.key(name), why, exc_info=True)
value = default
return value
return default