fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-22 23:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor APEv2File._save to make use of _get_tag_name

Browse Source
This commit is contained in:
Philipp Wolfer
2018-10-16 09:01:43 +02:00
parent 6ac71b848d
commit c83c9d3a09
1 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
picard/formats/apev2.py
View File

@@ -142,18 +142,13 @@ class APEv2File(File):
for name, value in metadata.items():
if name.startswith("~"):
continue
if name.startswith('lyrics:'):
name = 'Lyrics'
elif name == "date":
name = "Year"
real_name = self._get_tag_name(name)
# tracknumber/totaltracks => Track
elif name == 'tracknumber':
name = 'Track'
if name == 'tracknumber':
if 'totaltracks' in metadata:
value = '%s/%s' % (value, metadata['totaltracks'])
# discnumber/totaldiscs => Disc
elif name == 'discnumber':
name = 'Disc'
if 'totaldiscs' in metadata:
value = '%s/%s' % (value, metadata['totaldiscs'])
elif name in ('totaltracks', 'totaldiscs'):
@@ -161,16 +156,11 @@ class APEv2File(File):
# "performer:Piano=Joe Barr" => "Performer=Joe Barr (Piano)"
elif name.startswith('performer:') or name.startswith('comment:'):
name, desc = name.split(':', 1)
name = name.title()
if desc:
value += ' (%s)' % desc
elif name in self.__rtranslate:
name = self.__rtranslate[name]
else:
name = name.title()
temp.setdefault(name, []).append(value)
temp.setdefault(real_name, []).append(value)
for name, values in temp.items():
tags[str(name)] = values
tags[name] = values
for image in metadata.images_to_be_saved_to_tags:
cover_filename = 'Cover Art (Front)'
cover_filename += image.extension
@@ -180,7 +170,6 @@ class APEv2File(File):
# (mp3tags does this, but it's against the specs)
self._remove_deleted_tags(metadata, tags)
tags.save(encode_filename(filename))
def _remove_deleted_tags(self, metadata, tags):