fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-04-28 23:31:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-1346: Use sets to avoid O(n²) iteration when moving files

Browse Source
This commit is contained in:
Philipp Wolfer
2018-09-17 17:59:36 +02:00
parent bdbc541ddc
commit d3e4bc91ea
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
picard/file.py
View File

@@ -427,11 +427,11 @@ class File(QtCore.QObject, Item):
old_path = os.path.dirname(old_filename)
new_path = os.path.dirname(new_filename)
try:
names = os.listdir(old_path)
names = set(os.listdir(old_path))
except os.error:
log.error("Error: {} directory not found".naming_format(old_path))
return
filtered_names = [name for name in names if name[0] != "."]
filtered_names = {name for name in names if name[0] != "."}
for pattern in config.setting["move_additional_files_pattern"].split():
pattern = pattern.strip()
if not pattern:
@@ -440,9 +440,10 @@ class File(QtCore.QObject, Item):
file_names = names
if pattern[0] != '.':
file_names = filtered_names
for old_file in file_names:
for old_file in set(file_names):
if pattern_regex.match(old_file):
file_names.remove(old_file)
names.discard(old_file)
filtered_names.discard(old_file)
new_file = os.path.join(new_path, old_file)
old_file = os.path.join(old_path, old_file)
# FIXME we shouldn't do this from a thread!