fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-01-06 08:34:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,200 Commits 1 Branch 0 Tags
01e8a988d69b3d38605cff244ff72504eee1ea33
Commit Graph

3200 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
01e8a988d6 Ignore 404 errors for release group json 
We currently have no easy mean to know if there is cover art for the release group as we do for the release.

Not a perfect solution, ideas and patches are welcome.
We should not query the json file at all if we know there is no cover art for this release group.
 2014-07-10 12:49:29 +02:00
Laurent Monin
e46f4997b9 _caa_path() -> property 2014-07-10 12:31:05 +02:00
Laurent Monin
8f1a9b333c Do not hide exceptions from cover art providers 2014-07-10 12:29:51 +02:00
Laurent Monin
66718886de Make CoverArtProviderCaaReleaseGroup inherits from CoverArtProviderCaa 
It solved many issues, re-use json parsing code, and handling of various caa options (types, sizes, etc..)
 2014-07-10 12:05:17 +02:00
Laurent Monin
6706d57d35 Be sure to continue on next provider if no front image is found. 2014-07-09 21:23:15 +02:00
Laurent Monin
6e9fa8c5ed Remove useless line after acab1dc 2014-07-09 21:18:53 +02:00
Laurent Monin
54d3ccb8be Honour CAA image size preferences (full/250/500) 2014-07-09 21:15:43 +02:00
Laurent Monin
acab1dc985 Move fallback option to cover archive options group 2014-07-09 21:15:16 +02:00
Laurent Monin
932a3267b9 Fallback -> Fall back 2014-07-09 21:06:19 +02:00
Laurent Monin
b1c71c9686 Images can have other types (png, jpg, gif), remove '.jpg' 2014-07-09 19:50:19 +02:00
Laurent Monin
f75aa358fb PICARD-418: fallback to using release group cover 
It adds the option to use release group cover art from CAA.
It is required to enable CAA and release group fallback is disabled by default
 2014-07-09 12:22:57 +02:00
Wieland Hoffmann
84ffe3502f Fix the last commit 
because I forgot to `git add` the file again
 2014-06-28 21:14:13 +02:00
Wieland Hoffmann
50bc0755af Reset self.form_values after generating the HTML file 
Otherwise, :qa
 2014-06-28 21:12:52 +02:00
Laurent Monin
233e1403cb Merge pull request #345 from phw/fix-script-function-with-zero-arguments 
Fix evaluation of script functions with zero arguments.
 2014-06-26 11:18:15 +02:00
Philipp Wolfer
c6446626aa Better fix for script functions with zero arguments. 2014-06-25 22:08:10 +02:00
Laurent Monin
56d4d74ae0 Update translation files 2014-06-23 12:13:44 +02:00
Laurent Monin
21932662af Update picard.pot file 2014-06-23 12:08:44 +02:00
Laurent Monin
1884e4abba Merge pull request #347 from phw/fix-load-options-on-script-error 
Load the options dialog even if there is a ScriptError.
 2014-06-23 12:03:44 +02:00
Laurent Monin
d159fd6abe Merge pull request #346 from phw/plugin-fixes 
Fixed plugin precedence for the first plugin in plugin list.
 2014-06-23 12:03:22 +02:00
Philipp Wolfer
f2f8df11da Load the options dialog even if there is a ScriptError. 
Before a ScriptError, which is rasied for e.g. a missing function, the options dialog would not show up. This prevents the user from even fixing the scripting.
 2014-06-22 20:48:53 +02:00
Philipp Wolfer
aa89e5a3a3 Fixed plugin precedence for the first plugin in plugin list. 
If a plugin was in both the system wide and ther user's plugin folder and the plugin was the first in the list the plugin was loaded and listed twice.
 2014-06-22 20:25:46 +02:00
Philipp Wolfer
45984d0172 Fix evaluation of script functions with zero arguments. 2014-06-22 20:12:56 +02:00
Laurent Monin
050b81a16c Merge pull request #344 from xlotlu/master 
filename shortening needs file extension to make decisions.
 2014-06-21 20:09:42 +02:00
Ionuț Ciocîrlan
c60751559e filename shortening needs file extension to make decisions. 
closes #PICARD-613
 2014-06-21 20:26:14 +03:00
Wieland Hoffmann
d95a7221b1 Merge branch 'sophist_fix_default_naming_script' of https://github.com/Sophist-UK/picard 2014-06-20 10:31:49 +02:00
Wieland Hoffmann
9dfecd60bf Merge branch 'video' of https://github.com/phw/picard 2014-06-20 10:30:47 +02:00
Wieland Hoffmann
f41d3203fd Merge branch 'albumartist_website_fix' of https://github.com/zas/picard 2014-06-20 10:27:59 +02:00
Laurent Monin
e5953457b6 Not having 'relation_list' is not invalid, do not emit error message 
Error message is still emitted if metadata has no artist (which shouldn't happen for artist query)

E: 17:27:06 Album Artist Website: u'2451caed-5d09-456f-b640-5880b6060a64': MusicBrainz artist xml result not in correct format - {'attribs': {}, 'text': u'', 'children': {u'metadata': [{'attribs': {}, 'text': u'', 'children': {u'artist': [{'attribs': {u'type': u'Group', u'id': u'2451caed-5d09-456f-b640-5880b6060a64'}, 'text': u'', 'children': {u'name': [{'attribs': {}, 'text': u'Sir Frankie Crisp', 'children': {}}], u'sort_name': [{'attribs': {}, 'text': u'Sir Frankie Crisp', 'children': {}}]}}]}}]}}
 2014-06-20 10:10:10 +02:00
Laurent Monin
033d88362b Fix up albumartist_website plugin debug message 
Traceback (most recent call last):
  File "picard\webservice.pyo", line 285, in _process_reply
  File "C:\Program Files (x86)\MusicBrainz Picard\plugins\albumartist_website.py", line 95, in website_process
    log.debug("%s: %r: Artist Official Homepages = %s", PLUGIN_NAME, artistId, url)
NameError: global name 'url' is not defined
 2014-06-20 10:01:16 +02:00
Laurent Monin
68f88a73fe Merge pull request #339 from zas/config_path_in_debug 
Display configuration file or registry path in debug log
 2014-06-14 15:19:30 +02:00
Laurent Monin
c703d2cbb1 Merge pull request #338 from zas/cover_art_show 
Double-clicking on images in info dialog open them in external viewer
 2014-06-14 15:19:11 +02:00
Philipp Wolfer
4e89212940 Support .ogv video files 2014-06-13 19:17:51 +02:00
Philipp Wolfer
0793d71e67 Support ASF video file formats (reverted from commit 7494155d0c) 2014-06-13 19:16:40 +02:00
Laurent Monin
30c48db06c Display configuration file or registry path in debug log 2014-06-10 14:24:48 +02:00
Wieland Hoffmann
094094b1dd Add coverartproviders to the package list 2014-06-01 10:40:25 +02:00
Laurent Monin
9ddab79cc9 Double-clicking on images in info dialog open them in external viewer 2014-05-29 11:09:02 +02:00
Laurent Monin
ad2669331c Merge pull request #332 from zas/cover_art_pdf 
Improve handling of PDF cover art from CAA
 2014-05-29 10:10:01 +02:00
Laurent Monin
853e7e9bb5 images_to_be_saved_to_tags(): use can_be_saved_to_tags property 2014-05-29 09:30:18 +02:00
Laurent Monin
f544a4f44f Eventually raise CoverArtImageIOError when getting CoverArtImage.data 2014-05-29 09:13:26 +02:00
Laurent Monin
9ab5d72594 Introduce CaaThumbnailCoverArtImage and properties to handle thumbnails 
- can_be_saved_to_tags
PDFs cannot be saved to tags as today

- can_be_saved_to_disk
thumbnails shouldn't saved to disk (in audio files directory), they are only used for display

- can_be_saved_to_metadata
thumbnails aren't saved to audio files metadata
 2014-05-29 09:02:26 +02:00
Laurent Monin
54cc1e4c8d CaaCoverArtImage: describe thumbnail and is_thumbnail 2014-05-28 20:39:05 +02:00
Laurent Monin
442b41ed4a Merge pull request #336 from zas/cover_art_providers 
Split cover art providers to their own classes and files
 2014-05-28 17:30:13 +02:00
Laurent Monin
30eac04cbf Display thumbnail image for PDFs in info dialog 
It requires few changes in CaaCoverArtImage, basically one property (is_thumbnail) to indicate
the image is a thumbnail so it isn't added to metadata.
And a thumbnail property to link main image to its thumbnail.
 2014-05-28 17:29:41 +02:00
Laurent Monin
c7f224fe8f Move _queue_from_caa() code to _caa_json_downloaded(), simplify 2014-05-28 17:06:18 +02:00
Laurent Monin
0e6572fad3 CaaCoverArtImage: specify constructor, accept is_front 2014-05-28 16:57:19 +02:00
Laurent Monin
fdab5efa78 Download pdf cover art only if needed, download main file, not thumbnails. 
This patch solves 2 issues:
- pdf files only need to be saved if "save_images_to_files" option is set, PDFs are never embedded in tags
- ignore "caa_image_size" option which causes thumbnail of the pdf to be downloaded instead of the main file
 2014-05-28 16:57:14 +02:00
Laurent Monin
91b8a5ad20 Improve handling of PDF cover art from CAA 
- detect PDFs in imageinfo
- exclude PDFs from images to be written to tags
- display info about PDF in info dialog (need more work)
 2014-05-28 16:53:04 +02:00
Laurent Monin
0988a7db37 Describe CoverArtProvider class 2014-05-28 16:12:02 +02:00
Laurent Monin
c84173190f Fix up CoverArtProvider.match_url_relations description 2014-05-28 15:35:13 +02:00
Laurent Monin
8c651af501 Clarify queue_downloads() return values 2014-05-28 15:33:31 +02:00