Commit Graph

7925 Commits

Author SHA1 Message Date
Philipp Wolfer
0d2ed06e60 Use new help implementation for CAATypesSelectorDialog 2021-05-04 15:41:27 +02:00
Laurent Monin
1f5668ee17 Get rid of webbrowser.goto()
Check if `url` passed is a key from `PICARD_URLS`, and uses the value if it is.
2021-05-04 15:41:27 +02:00
Philipp Wolfer
4a87eda65b Add common functionality to open help to PicardDialog 2021-05-04 15:41:27 +02:00
Philipp Wolfer
2702229bf2 PICARD-2201: Add a help button to "Tags from file names" dialog 2021-05-04 13:22:14 +02:00
Philipp Wolfer
4db079399a PICARD-1568: Pre-compile expressions for tracknum_from_filename 2021-05-01 20:50:24 +02:00
Philipp Wolfer
ef62e311dd PICARD-1568: extended tests for tracknum_from_filename
Include most of the tests from test_tracknum.py. Changed a few tests as we got rid of the logic to choose the smallest of all numbers found.
2021-05-01 20:50:24 +02:00
Philipp Wolfer
19d973c36d PICARD-1568: Improve parsing track number from filenames
Avoid false positives, allow some common cases only instead of parsing all numbers.
2021-05-01 20:50:24 +02:00
Philipp Wolfer
f590cedf97 Update picard.pot 2021-05-01 16:38:36 +02:00
Philipp Wolfer
8627155471 Merge pull request #1798 from phw/PICARD-2171-optional-guess-title
PICARD-2171: Optional guess title and tracknumber
2021-05-01 08:50:08 +02:00
Philipp Wolfer
a73e65fcc3 Allow postprocessors in File._copy_loaded_metadata 2021-04-30 20:21:52 +02:00
Philipp Wolfer
cb00cefc48 Disabled pylint no-self-use 2021-04-30 17:09:12 +02:00
Philipp Wolfer
95cc8fde92 Handle some pylint and bandit warnings 2021-04-30 17:09:12 +02:00
Philipp Wolfer
ac3d449e07 Removed unused constants from ScriptEditorPage 2021-04-30 11:58:52 +02:00
Laurent Monin
336220a3b5 Minor rewrite, code simplification (#4)
* eventFilter(): Match event.type() using a set

* toggle_documentation(): use setVisible() to simplify code
2021-04-30 11:58:52 +02:00
Bob Swift
084e162c0f Make tagger argument non-optional. Fix incorrect reference. 2021-04-30 11:58:52 +02:00
Bob Swift
def7d9176b Revise arguments to ScriptEditorExamples. Remove unsused parent. 2021-04-30 11:58:52 +02:00
Bob Swift
3e8634bd69 Correction to docstring 2021-04-30 11:58:52 +02:00
Bob Swift
3dd6d06897 Remove unused send_signal option. 2021-04-30 11:58:51 +02:00
Laurent Monin
9c34b67c66 Convert default_examples() to a generator (#3) 2021-04-30 11:58:51 +02:00
Laurent Monin
038c55dcfb Replace example_1() & example_2() with default_examples()
- Use a dict for metadata
- easier to extend
2021-04-30 11:58:51 +02:00
Bob Swift
0da8d5c3c7 Missing updated file that should have been on commit cc27862. (Oops) 2021-04-30 11:58:51 +02:00
Bob Swift
b0aa93ed37 Set file types as class properties to reduce duplication. 2021-04-30 11:58:51 +02:00
Bob Swift
4c21d5b17b Remove unused wordwrap property. 2021-04-30 11:58:51 +02:00
Bob Swift
2a85fa2a1f Set maximum examples, tooltip and usage notes as class properties. 2021-04-30 11:58:45 +02:00
Bob Swift
be18bcbfb8 Additional code de-duplication 2021-04-30 11:51:19 +02:00
Bob Swift
1e32469a39 Create function for syncing scroll bars to remove duplicated code. 2021-04-30 11:51:19 +02:00
Bob Swift
5c68931235 Remove highlight from splitters 2021-04-30 11:51:19 +02:00
Bob Swift
27f62a7380 Highlight splitters to make them more visible. 2021-04-30 11:51:19 +02:00
Bob Swift
b67aaaf4bc Update TODO comment. 2021-04-30 11:51:19 +02:00
Bob Swift
99f829493c Use custom widget for documentation display from scriping options page 2021-04-30 11:51:19 +02:00
Bob Swift
8b2cbcd13f Refactor documentation template into scripting documentation module 2021-04-30 11:51:19 +02:00
Bob Swift
a4b3b29ca0 Move ScriptingDocumentationWidget to picard.ui.widgets 2021-04-30 11:51:18 +02:00
Bob Swift
1f8b1537e0 Remove unused layout 2021-04-30 11:51:18 +02:00
Bob Swift
6c68f85af3 Make ScriptingDocumentationWidget a proper stand-alone widget. 2021-04-30 11:51:18 +02:00
Bob Swift
bd0f479535 Don't use underscore for unused variables. 2021-04-30 11:51:18 +02:00
Bob Swift
27850fdd33 Set default path and file name as class properties. 2021-04-30 11:51:18 +02:00
Bob Swift
2a850861df Set import/export default directory. Mark dialog titles for translation. 2021-04-30 11:51:18 +02:00
Bob Swift
fba146c1b2 Fix call argument to error display from import/export. Add logging. 2021-04-30 11:51:18 +02:00
Bob Swift
ac66c32cf9 Clean up call to super() when initializing the documentation widget 2021-04-30 11:51:18 +02:00
Bob Swift
649c4c50eb Changes requested by outsidecontext
- remove SingletonDialog from ScriptEditorPage class
- remove unused self.parent and self.PARENT variables
- remove setWindowFlags and add setWindowModality
- create custom ScriptingDocumentationWidget
2021-04-30 11:51:18 +02:00
Bob Swift
c4f4ab4393 Fix docstring 2021-04-30 11:51:18 +02:00
Laurent Monin
97249994f6 Disable export/save buttons if script has errors 2021-04-30 11:51:18 +02:00
Laurent Monin
7c3e3498c3 Simplify preset script selection code 2021-04-30 11:51:18 +02:00
Laurent Monin
3dbaef3656 Get rid of empty script, let syntax checking do the work 2021-04-30 11:51:18 +02:00
Bob Swift
df4bc6d144 Fix position of Show documentation checkbox. Remove unused splitter. 2021-04-30 11:51:18 +02:00
Bob Swift
85e5bf8e46 Implement suggested changes
- Include current configuration naming script in selection list
- Update script loaded into the editor on selection change
- Only update script on "Make it so" if it has been saved from editor
- Optimize synchronization of example lists
- Correct spelling mistakes
2021-04-30 11:51:18 +02:00
Bob Swift
367afeba21 Add missing tooltip 2021-04-30 11:51:18 +02:00
Bob Swift
1708bbc07c Add option to display scripting documentation on the editor screen 2021-04-30 11:51:18 +02:00
Bob Swift
7267778047 Slight refactoring. Add docstrings. 2021-04-30 11:51:17 +02:00
Bob Swift
955ea990ff Use self.set_script() to avoid code duplication. 2021-04-30 11:51:17 +02:00