fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-03-06 21:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,515 Commits 1 Branch 0 Tags
2f34f3cd2e920c63df669c282cedd5521b7c2675
Commit Graph

8515 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Philipp Wolfer
2f34f3cd2e Fixed appx signing 2021-11-10 15:05:56 +01:00
Philipp Wolfer
f22c3ea965 Use SecureString in Windows Powershell packaging script 2021-11-10 14:59:42 +01:00
Philipp Wolfer
49931a136e Renamed mock classes in test_log 
Avoids warnings by pytest trying to interpret these classes as test fixtures.
 2021-11-10 08:08:50 +01:00
Philipp Wolfer
a01f28d0c0 PICARD-2327: Detect hidden files on macOS 2021-11-10 08:02:50 +01:00
Philipp Wolfer
5de0efc025 Merge pull request #1940 from zas/file_move_rename 
Rework additional files methods
 2021-11-10 08:02:28 +01:00
Philipp Wolfer
8988f8692e PICARD-2328: Fix "arguments did not match any overloaded call" error with Python 3.10 2021-11-10 05:51:49 +01:00
Laurent Monin
54ba988666 Test _get_additional_files_moves() 2021-11-09 23:15:23 +01:00
Laurent Monin
4e9aa419ba _get_additional_files_moves(): Move exception handling to caller 
It will be easier to test if exception is correctly raised
 2021-11-09 23:13:23 +01:00
Laurent Monin
32032de3c2 Move settings from module level to class level, as it is only used there 2021-11-09 22:32:28 +01:00
Laurent Monin
0651a7c34b Simplify test_filesystem 
- try to make it a bit more readable
- move prepare_files() outside test class, so it can easily be re-used
- use name of files directly
- split files dict in two: src & dst
 2021-11-09 22:27:13 +01:00
Laurent Monin
93a8d83365 Make _compile_move_additional_files_pattern() a static method and simplify tests 
- do not pass config but the patterns string
- make it a static method (it doesn't need self anyway)
- simplify tests accordingly
 2021-11-09 21:43:40 +01:00
Laurent Monin
2d7e8cde9f Partially revert previous patches, keeping parameters as they were 
https://github.com/metabrainz/picard/pull/1940#discussion_r745955335
https://github.com/metabrainz/picard/pull/1940#discussion_r745956334
 2021-11-09 21:05:38 +01:00
Philipp Wolfer
10caa13975 Add Windows specific unit test for util.is_hidden 2021-11-09 20:58:17 +01:00
Laurent Monin
f4a27d91aa _move_additional_files(): invert logic, and remove returns 2021-11-09 18:12:13 +01:00
Laurent Monin
db89562958 _get_additional_files_moves(): make it a generator 
- there's no need for a set, as entries are unique
 2021-11-09 18:04:28 +01:00
Laurent Monin
1486bdb0f0 _apply_additional_files_moves(): call _get_additional_files_moves() directly 
- pass old_path, new_path, config instead of moves
 2021-11-09 17:58:05 +01:00
Laurent Monin
725033c55e Call _compile_move_additional_files_pattern() directly from _get_additional_files_moves() 
- pass config parameter to _get_additional_files_moves() instead of patterns
 2021-11-09 17:55:49 +01:00
Laurent Monin
cd188dcebf Rewrite to use a set comprehension 
- using strip() isn't needed as split(sep=None) will take care of multiple whitespaces
- from 10 lines to 4, and likely a tad faster
 2021-11-09 17:45:26 +01:00
Laurent Monin
37982bed94 Also test weird whitespacing, multiple or newlines 2021-11-09 17:42:48 +01:00
Laurent Monin
baba955cf0 Since the pattern matching is case-insensitive, lowercase pattern string 
- it helps to remove duplicates (like cover.jpg cover.JPG)
- fix test accordingly
 2021-11-09 17:27:15 +01:00
Philipp Wolfer
3d8bfe9d4a Release 2.7.0b2 2021-11-09 13:26:43 +01:00
Laurent Monin
21c5722f5a Add tests for File._compile_move_additional_files_pattern() 2021-11-09 13:18:27 +01:00
Philipp Wolfer
ca85e64cc8 Updated translations from transifex 2021-11-09 12:22:22 +01:00
Philipp Wolfer
a67ca328fc Merge pull request #1938 from phw/PICARD-2324-fix-wvc-rename 
PICARD-2324: Fix renaming of WavPack correction files
 2021-11-09 12:03:06 +01:00
Philipp Wolfer
7683ca0688 Reduce code complexity in File._move_additional_files 2021-11-09 11:44:58 +01:00
Philipp Wolfer
a66b2ad779 PICARD-2324: Run .wvc rename code only if rename_files or move_files are set 2021-11-09 11:02:34 +01:00
Philipp Wolfer
d8406b5159 PICARD-2324: Move .wvc files before moving additional files 2021-11-09 11:02:34 +01:00
Philipp Wolfer
7cab070f74 PICARD-2324: Fix renaming of WavPack correction files 2021-11-09 08:51:25 +01:00
Philipp Wolfer
1686b7eb9c imagelist.add_metadata_images must return False on empty image list 2021-11-07 15:01:18 +01:00
Philipp Wolfer
a337bd0d20 PICARD-2322: Update album images after load and matching files 2021-11-07 15:01:18 +01:00
Philipp Wolfer
dbc236c48b Optimize imagelist.add_metadata_images 
Only update image list if new images are not already in the existing images. Also return bool value as indicated in the function documentation.
 2021-11-07 15:01:18 +01:00
Philipp Wolfer
0b3b2658af PICARD-2321: Fix "Keep original cover art" for trcks with attached files 2021-11-07 15:01:18 +01:00
Philipp Wolfer
d3aaf50a4a Build macOS package with Python 3.9.8 2021-11-07 14:55:22 +01:00
Philipp Wolfer
9c382562ab Exclude Python 3.10 tests on macOS 
pyobjc is not yet compatible with Python 3.10 and hence this is unsupported.
 2021-11-07 11:27:33 +01:00
Philipp Wolfer
bbafe6090e Run tests on Python 3.10 2021-11-07 10:08:14 +01:00
Philipp Wolfer
dd80c1d078 Use set comprehension where appropriate 2021-11-07 10:08:14 +01:00
Philipp Wolfer
656eba5af4 PICARD-2318: Allow AB submission only for files matched to tracks 2021-11-07 10:02:52 +01:00
Laurent Monin
bf30330f3a Merge pull request #1935 from phw/check-in-sets 
Check in sets
 2021-10-31 16:29:35 +01:00
Philipp Wolfer
aed015c657 Use sets in apev2 tests 2021-10-31 15:29:32 +01:00
Philipp Wolfer
cb6973cf44 Use sets instead of lists in conditionals 2021-10-31 10:17:23 +01:00
Philipp Wolfer
72f7d0ed18 Use sets for format unsupported tags 2021-10-31 09:56:14 +01:00
Laurent Monin
7c133891bd Merge pull request #1933 from phw/PICARD-2314-fix-mp4-freetext-length 
PICARD-2314: Fix ~length getting written to MP4 ----:com.apple.iTunes:~length
 2021-10-31 09:43:59 +01:00
Philipp Wolfer
d5f131da04 PICARD-2307: Fix ValueError for Vorbis when deleting invalid tags 2021-10-29 18:13:47 +02:00
Philipp Wolfer
7a37e25152 vorbis: empty string is not a valid Vorbis comment key 2021-10-29 18:13:47 +02:00
Philipp Wolfer
8154af24c9 PICARD-2311: Preserve ID3 APIC types for loaded images 2021-10-29 18:13:16 +02:00
Philipp Wolfer
b7179d36fc Move ID3 image type functions to picard.coverart.utils 2021-10-29 18:13:16 +02:00
Philipp Wolfer
a7f0a27f92 Exclude technical variables like ~length from format supported tags 
Those values are taken from technical format information and are not part of the tags. This also fixes ~length getting written to MP4 (PICARD-2314).
 2021-10-29 00:11:02 +02:00
Philipp Wolfer
73147cd949 PICARD-2308: addrelease now sets the track artist credits 2021-10-25 12:06:49 +02:00
Laurent Monin
695b63faee PICARD-2306: set convert_punctuation option to False by default 
It was set to True a long time ago, when Unicode wasn't as widely supported.
 2021-10-22 15:21:24 +02:00
Philipp Wolfer
f582d39d1c Update picard.pot 2021-10-21 18:43:01 +02:00