Commit Graph

4799 Commits

Author SHA1 Message Date
Wieland Hoffmann
452a78aaf6 Don't use assert_called
It's only available in Python 3.6+
2017-07-10 20:34:16 +02:00
Wieland Hoffmann
690e385255 Use unittest.mock instead of mock
mock is not part of the standard library, only unittest.mock is.
2017-07-10 20:26:35 +02:00
Laurent Monin
333b249707 Merge pull request #753 from samj1912/wsref
Refactor the webservice code
2017-07-10 13:07:32 +02:00
Sambhav Kothari
9df404172a Add more tests for WebService 2017-07-10 15:58:49 +05:30
samj1912
d71fb8d57a Merge pull request #754 from scop/spelling
Spelling fixes
2017-07-10 01:30:08 +05:30
Ville Skyttä
ea0bd878b5 Spelling fixes 2017-07-09 22:16:48 +03:00
Sambhav Kothari
6145b0dd67 Fix imports 2017-07-09 21:49:43 +05:30
Sambhav Kothari
dcaa3f4e84 Add basic code to test Webservice 2017-07-09 21:37:52 +05:30
Sambhav Kothari
0ef8fd0f05 Move API constants and add Unknown parser error 2017-07-09 17:44:35 +05:30
Sambhav Kothari
181d04e32e Refactor the webservice code to allow hooking of response parsers 2017-07-09 14:04:33 +05:30
Sambhav Kothari
c469531797 Rename variables appropriately and add exception on improper response parser 2017-07-08 22:37:22 +05:30
Sambhav Kothari
ad9647374d Refactor code for api helpers 2017-07-08 22:28:11 +05:30
Sambhav Kothari
ee97c4e73a Fix copy errors 2017-06-24 17:24:40 +05:30
Sambhav Kothari
d5d31d52bf Add file header 2017-06-24 16:47:23 +05:30
Sambhav Kothari
d9f5a226f6 Fix codacy errors and style issues 2017-06-24 16:38:04 +05:30
Sambhav Kothari
04a987be1d Remove unexpected argument from post api helper 2017-06-24 16:16:12 +05:30
Sambhav Kothari
6ba3d13d84 Fix erronous code: Return data from api functions 2017-06-24 16:08:43 +05:30
Sambhav Kothari
d5287b48eb Update the refactored webservice changes in other files 2017-06-24 15:58:09 +05:30
Sambhav Kothari
2f3cdbae44 Refactor webservice code 2017-06-24 15:57:42 +05:30
Wieland Hoffmann
c488d1784c Merge pull request #752 from mineo/shutil-copystat
_patched_shutil_copystat: Support the follow_symlinks keyword argument
2017-06-08 22:43:51 +02:00
Wieland Hoffmann
e1508b9b8e Merge branch 'master' into shutil-copystat 2017-06-08 22:38:08 +02:00
Wieland Hoffmann
d77be045e6 _patched_shutil_copystat: Support the follow_symlinks keyword argument
shutil.copystat supports it and there's some code called by Picard (for example
when trying to install plugins) that passes the argument. Support it to fix
crashes in those cases.
2017-06-07 20:24:19 +02:00
samj1912
70dc9c7787 Merge pull request #751 from mineo/picard-1106
PICARD-1106: Discard the second return value of QFileDialog.getOpenFileNames
2017-06-07 23:54:08 +05:30
Wieland Hoffmann
6c0f18b04d PICARD-1106: Discard the second return value of QFileDialog.getOpenFileNames
getOpenFileNames was previously called getOpenFileNamesAndFilter (see [0]) and
returns a tuple (filenames, filter). Since we're not interested in the filter,
discard it.

This is similar to other fixes already done for QFileDialogs in mainwindow.py
and fingerprinting.py.

[0] http://pyqt.sourceforge.net/Docs/PyQt5/pyqt4_differences.html#qfiledialog
2017-06-07 20:01:35 +02:00
Wieland Hoffmann
5d71f9d749 _patched_shutil_copystat: Add a working URL for the bug this fixes 2017-06-07 19:49:26 +02:00
Laurent Monin
dbf05b2631 Merge pull request #750 from mineo/PICARD-1105
PICARD-1105: Use QItemSelectionModel from QtCore
2017-06-06 20:29:42 +02:00
Wieland Hoffmann
c7cf905f6e PICARD-1105: Use QItemSelectionModel from QtCore
It has been moved there from QtWidgets
2017-06-06 20:15:45 +02:00
samj1912
ab70e18b4e Merge pull request #749 from samj1912/gsettings
PICARD-1100: Remove deprecated gconf and move to gsettings
2017-06-01 08:02:14 +05:30
Sambhav Kothari
0d6b169980 PICARD-1100: Remove deprecated gconf and move to gsettings
Solves https://tickets.metabrainz.org/projects/PICARD/issues/PICARD-1100
2017-05-31 22:39:20 +05:30
Laurent Monin
9c938ee7b0 Merge pull request #743 from mineo/rm-docker
Remove Dockerfile
2017-05-28 12:42:55 +02:00
samj1912
7fe80411a3 Merge pull request #746 from samj1912/revert_pypi
Revert pypi_dev related changes
2017-05-25 10:19:12 +05:30
Sambhav Kothari
176d0f958e Revert pypi_dev related changes 2017-05-24 23:01:26 +05:30
samj1912
bdd4ce2e3f Merge pull request #745 from mineo/readme-travis-link
Add the link to the test results to the travis badge
2017-05-21 23:38:46 +05:30
Wieland Hoffmann
a561b1721e Add the link to the test results to the travis badge
This is actually the markdown you get from travis, I'm not sure where the one
without the link came from.
2017-05-21 19:17:03 +02:00
Wieland Hoffmann
67e74a75c7 Remove Dockerfile
It's not used on travis anymore and is already outdated regarding what's
tested and the settings used for running the tests.
2017-05-21 17:56:49 +02:00
samj1912
669aeb0fd6 Merge pull request #742 from Sophist-UK/rename-variables-redefining-builtins
Rename variables redefining builtins
2017-05-19 07:51:10 +05:30
Sophist
24bd2a0e36 Maintain naming consistency 2017-05-18 17:20:24 +01:00
Sophist
b94680e09c Rename variables redefining builtins - test_textencoding.py 2017-05-18 11:30:38 +01:00
Sophist
1ff1db0f90 Rename variables redefining builtins - webservice.py 2017-05-18 11:30:23 +01:00
Sophist
32695b7669 Rename variables redefining builtins - thread.py 2017-05-18 11:30:07 +01:00
Sophist
29729782dd Rename variables redefining builtins - tagsfromfilenames.py 2017-05-18 11:29:50 +01:00
Sophist
7db32566e2 Rename variables redefining builtins - ui/options/tags.py 2017-05-18 11:29:33 +01:00
Sophist
a7e25beb25 Rename variables redefining builtins - infodialog.py 2017-05-18 11:29:11 +01:00
Sophist
6415840479 Rename variables redefining builtins - filebrowser.py 2017-05-18 11:28:56 +01:00
Sophist
3f74b6935e Rename variables redefining builtins - track.py 2017-05-18 11:28:47 +01:00
Sophist
6e73b48f87 Rename variables redefining builtins - tagger.py 2017-05-18 11:28:38 +01:00
Sophist
e097b02a5a Rename variables redefining builtins - releasegroup.py 2017-05-18 11:28:21 +01:00
Sophist
3ba817f92c Rename variables redefining builtins - mbxml.py 2017-05-18 11:28:11 +01:00
Sophist
3fcbc524a0 Rename variables redefining builtins - formats 2017-05-18 11:27:56 +01:00
Sophist
7b525c95a2 Rename variables redefining builtins - asf.py 2017-05-18 11:27:28 +01:00