* only repeats the preceding regular expression, but in the old test, there was
nothing preceding it. This showed up when tests were executed via `python
setup.py test`:
> .........................................E: 20:54:38,617 /home/wieland/dev/picard/picard/track.__init__:88: Failed to compile regex /*/: nothing to repeat at position 0
> Traceback (most recent call last):
> File "/home/wieland/dev/picard/picard/track.py", line 86, in __init__
> regex_search = re.compile(remain, re.IGNORECASE)
> File "/usr/lib/python3.7/re.py", line 234, in compile
> return _compile(pattern, flags)
> File "/usr/lib/python3.7/re.py", line 286, in _compile
> p = sre_compile.compile(pattern, flags)
> File "/usr/lib/python3.7/sre_compile.py", line 764, in compile
> p = sre_parse.parse(p, flags)
> File "/usr/lib/python3.7/sre_parse.py", line 930, in parse
> p = _parse_sub(source, pattern, flags & SRE_FLAG_VERBOSE, 0)
> File "/usr/lib/python3.7/sre_parse.py", line 426, in _parse_sub
> not nested and not items))
> File "/usr/lib/python3.7/sre_parse.py", line 651, in _parse
> source.tell() - here + len(this))
> re.error: nothing to repeat at position 0
This was swallowed by py.test's behaviour to swallow stdout & stderr if no tests
fail.
Remove `*` from test_regexfilter and add an additional test with `/.*/` to
ensure this works.
The genre filter UI handled this correctly by showing the re.error in the UI.
After 82c3e888a9d89e4d1aaa34c78f78eb14eb8bad63 the menu and toolbar CD lookup action was not updated to be a menu if more than one drive. This is now fixed. Also simplified to use the same action always in the menu.
Avoids Picard crashing if e.g. a plugin provides a broken OptionsPage implementation. This gives the user better feedback and eventually even allows user to recover from the situation.
If none of save images to tags or save images to files is enabled, cover art is totally disabled, greying out ca providers list somehow make it more obvious.
Current macOS builds do not run on macOS < 10.12. Setting LSMinimumSystemVersion enforces that this package cannot be started on older macOS versions with a proper message to the user.
Directly removing the NAT pseudo-album broke with c6815c4fad. This commit fixed the issue, that removing both the non-album tracks album and the last NAT track would cause a crash, since removal of the NAT album was attempted twice.
Solution: Allow direct removal of the NAT album, but ensure duplicate calls to remove_album() do not crash.
